Standardize blogging reminders migration - #17778
Merged
mkevins merged 5 commits intoJan 18, 2023
Merged
Conversation
This is useful to provide continuity of type inference through the usage of the orElse method, allowing it to be used in the middle of a result chain without obscuring the passed data subtype to downstream success handlers.
This also moves the blogging reminder migration step to be during the migration flow, instead of afterwards.
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 0d751e3 | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 0d751e3 | |
3 tasks
ovitrif
approved these changes
Jan 18, 2023
ovitrif
left a comment
ovitrif
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👏
Thank you @mkevins for implementing this enhancement to the WP → JP app content migration 👍
The code changes look consistent and valid to me, and the functionality works as described while testing ✅ 🎉
Leaving the merging decision to you 🙇
mkevins
deleted the
issue/17752-standardize-blogging-reminders-migration
branch
January 18, 2023 22:00
Contributor
Author
|
Thanks Ovi for reviewing and testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17752
Description
This PR updates the blogging reminders migration step, and moves its invocation to the orchestrator so that the data is migrated during the main migration flow (instead of afterwards in response to an
onSiteChangedevent). This makes the complete flow more robust in the case that a deep link lands in a place whereonSiteChangedis not subscribed for the blogging reminders migration to complete (relevant to #17742)To test:
jalapenoDebug, install JetpackjalapenoDebug) - expect to see the migration welcome screenRegression Notes
Potential unintended areas of impact
Migration flow.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual and automated tests.
What automated tests I added (or what prevented me from doing so)
The automated tests for this helper are currently disabled, and re-enabling them is large enough scope for a dedicated PR.
PR submission checklist:
RELEASE-NOTES.txtif necessary.