Removes ImageSettingsDialogFragment which is not used anymore - #19658
Merged
Conversation
antonis
marked this pull request as ready for review
November 23, 2023 14:57
18 tasks
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19658-e7938b7 | |
| Commit | e7938b7 | |
| Direct Download | jetpack-prototype-build-pr19658-e7938b7.apk |
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19658-e7938b7 | |
| Commit | e7938b7 | |
| Direct Download | wordpress-prototype-build-pr19658-e7938b7.apk |
antonis
marked this pull request as draft
November 23, 2023 16:16
Contributor
Author
|
Converting to draft to figure out the CI failures |
Generated by 🚫 dangerJS |
Contributor
Generated by 🚫 Danger |
Contributor
Author
Removed some extra unused resources with e7938b7 :) |
antonis
marked this pull request as ready for review
November 23, 2023 17:25
justtwago
approved these changes
Nov 27, 2023
justtwago
left a comment
Contributor
There was a problem hiding this comment.
Nice code removal! Tested the editor and it seems to work as usual 👌
Contributor
Author
|
Thank you for reviewing Artyom 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR removes
ImageSettingsDialogFragmentwhich is not used anymore as identified in #19568 (review)To Test:
Regression Notes
Editor
Manual testing
N/A since this PR involves code cleanup
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: