Skip to content

Removes ImageSettingsDialogFragment which is not used anymore #19658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 2 commits into from
Nov 28, 2023
Merged

Removes ImageSettingsDialogFragment which is not used anymore #19658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fddedc
Removes ImageSettingsDialogFragment which is not used in the code any…
antonis Nov 23, 2023
e7938b7
Removes unused resources
antonis Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
import org.wordpress.android.editor.EditorMediaUtils;
import org.wordpress.android.editor.EditorThemeUpdateListener;
import org.wordpress.android.editor.ExceptionLogger;
import org.wordpress.android.editor.ImageSettingsDialogFragment;
import org.wordpress.android.editor.gutenberg.DialogVisibility;
import org.wordpress.android.editor.gutenberg.GutenbergEditorFragment;
import org.wordpress.android.editor.gutenberg.GutenbergPropsBuilder;
Expand Down Expand Up @@ -1487,17 +1486,6 @@ public void onRequestPermissionsResult(int requestCode,
}

private boolean handleBackPressed() {
Fragment fragment = getSupportFragmentManager().findFragmentByTag(
ImageSettingsDialogFragment.IMAGE_SETTINGS_DIALOG_TAG);
if (fragment != null && fragment.isVisible()) {
if (fragment instanceof ImageSettingsDialogFragment) {
ImageSettingsDialogFragment imFragment = (ImageSettingsDialogFragment) fragment;
imFragment.dismissFragment();
}

return false;
}

if (mViewPager.getCurrentItem() == PAGE_PUBLISH_SETTINGS) {
mViewPager.setCurrentItem(PAGE_SETTINGS);
invalidateOptionsMenu();
Expand Down
597 changes: 0 additions & 597 deletions libs/editor/src/main/java/org/wordpress/android/editor/ImageSettingsDialogFragment.java
View file
Open in desktop

This file was deleted.

170 changes: 0 additions & 170 deletions libs/editor/src/main/res/layout/dialog_image_options.xml
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions libs/editor/src/main/res/layout/image_settings_formatbar.xml
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions libs/editor/src/main/res/values-w720dp/layouts.xml
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions libs/editor/src/main/res/values/dimens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,13 @@
<dimen name="sourceview_top_margin">15dp</dimen>
<dimen name="sourceview_title_bottom_margin">15dp</dimen>

<dimen name="image_settings_dialog_padding">16dp</dimen>
<dimen name="image_settings_dialog_extra_margin">0dp</dimen>
<dimen name="image_settings_dialog_extra_margin_tablet">84dp</dimen>
<dimen name="image_settings_dialog_label_indent">4dp</dimen>
<dimen name="image_settings_dialog_label_margin_bottom">4dp</dimen>
<dimen name="image_settings_dialog_input_margin_bottom">16dp</dimen>
<dimen name="image_settings_dialog_input_field_start_margin">-4dp</dimen>
<dimen name="image_settings_dialog_top_separator_margin_top">16dp</dimen>
<dimen name="image_settings_dialog_thumbnail_container_margin_bottom">8dp</dimen>
<dimen name="image_settings_dialog_thumbnail_size">100dp</dimen>
<dimen name="image_settings_dialog_thumbnail_progress_size">50dp</dimen>
<dimen name="image_settings_dialog_thumbnail_left_margin">4dp</dimen>
<dimen name="image_settings_dialog_thumbnail_right_margin">8dp</dimen>
<dimen name="image_settings_dialog_filename_margin_left">16dp</dimen>
Expand Down
1 change: 0 additions & 1 deletion libs/editor/src/main/res/values/layouts.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<bool name="is_large_tablet_landscape">false</bool>
<bool name="show_extra_side_padding">false</bool>
</resources>
12 changes: 0 additions & 12 deletions libs/editor/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,4 @@
<item name="android:layout_marginStart">@dimen/format_bar_button_group_tablet</item>
<item name="android:layout_marginEnd">@dimen/format_bar_button_group_tablet</item>
</style>

<style name="ImageOptionsDialogLabel">
<item name="android:textColor">@color/image_options_label</item>
<item name="android:textStyle">bold</item>
<item name="android:paddingLeft">@dimen/image_settings_dialog_label_indent</item>
<item name="android:paddingStart">@dimen/image_settings_dialog_label_indent</item>
<item name="android:layout_marginBottom">@dimen/image_settings_dialog_label_margin_bottom</item>
</style>

<style name="ImageOptionsDialogInput">
<item name="android:layout_marginBottom">@dimen/image_settings_dialog_input_margin_bottom</item>
</style>
</resources>