Skip to content

Updates: the tab bar icons and styling - #19794

Merged
zwarm merged 17 commits into
trunkfrom
issue/update-tab-bar-icons
Jan 5, 2024
Merged

Updates: the tab bar icons and styling#19794
zwarm merged 17 commits into
trunkfrom
issue/update-tab-bar-icons

Conversation

@AjeshRPai

@AjeshRPai AjeshRPai commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Fixes #

Description

Updates the icons in bottom bar nav in JP/WP app

Dark Light Mode
Screenshot 2024-01-03 at 3 51 14 PM Screenshot 2024-01-03 at 3 51 00 PM

Sets the me icon to B&W or with color depending on the selected state

me_icon_tint.webm

Adds a pop animation to the bottom nav icon on selecting

Note: please ignore the badge position on notification icon. It has been moved to left of the icon as before

Screen_recording_20240103_232835.webm

To Test:

  • Login to the JP/WP app
  • Go to the dashboard
  • Verify that the icons on the bottom bar as in the design P4DK0f5zK8F3Y1eifGqS39-fi-3:12381
  • Verify new tab icons adapt to environment (light vs dark)
  • Verify the icons animate when switching tabs
  • Verify the me icon gets blacked out when not selected
  • Verify notification icon shows the correct badge color when there are unread notifications (blue for WP, green for JP)

Regression Notes

  1. Potential unintended areas of impact
    Bottom bar icons are not correct

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot

wpmobilebot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19794-da60b59
Commitda60b59
Direct Downloadjetpack-prototype-build-pr19794-da60b59.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

wpmobilebot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19794-da60b59
Commitda60b59
Direct Downloadwordpress-prototype-build-pr19794-da60b59.apk
Note: Google Login is not supported on these builds.

@AjeshRPai AjeshRPai added the [Status] Needs Design Review A designer needs to sign off on the implemented design. label Jan 3, 2024
@AjeshRPai
AjeshRPai marked this pull request as ready for review January 3, 2024 10:16
@AjeshRPai

Copy link
Copy Markdown
Contributor Author

cc: @zwarm Pinging you so that you are aware of this change

@AjeshRPai
AjeshRPai requested a review from zwarm January 5, 2024 08:00
@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@AjeshRPai

Copy link
Copy Markdown
Contributor Author

Hey @zwarm

I am adding you as a reviewer since Chris is not available for the review. The IOS PR for these changes is wordpress-mobile/WordPress-iOS#22325

The haptics for the nav bar items were already in a past PR.

@zwarm zwarm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjeshRPai - I've tested the following
✅ Verify that the icons on the bottom bar as in the design
✅ Verify new tab icons adapt to environment (light vs dark)
🟡 Verify the icons animate when switching tabs
✅ Verify the me icon gets blacked out when not selected
✅ Verify notification icon shows the correct badge color when there are unread notifications (blue for WP, green for JP) - I had to turn notifications on to see the badge.

🟡 Verify the icons animate when switching tabs

  • Technically it works; however it doesn't feel clean - sometimes the animation takes too long and the icon completely disappears. And sometimes in dark mode you don't see the animation at all. See my attached video. Pixel 5 Android 14

I am going to leave this PR in request changes status to give you a chance to respond. If this is the expected behavior, then I will go ahead and approve the PR. lmk. Thanks

screen-20240105-075306.mp4

@zwarm
zwarm self-requested a review January 5, 2024 22:01

@zwarm zwarm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After syncing with @AjeshRPai , this PR will be merged and we'll take up any minor issues during beta week.

@zwarm
zwarm merged commit eb3a7c2 into trunk Jan 5, 2024
@zwarm
zwarm deleted the issue/update-tab-bar-icons branch January 5, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design My Site Dashboard [Status] Needs Design Review A designer needs to sign off on the implemented design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants