Updates: the tab bar icons and styling - #19794
Conversation
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19794-da60b59 | |
| Commit | da60b59 | |
| Direct Download | jetpack-prototype-build-pr19794-da60b59.apk |
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19794-da60b59 | |
| Commit | da60b59 | |
| Direct Download | wordpress-prototype-build-pr19794-da60b59.apk |
This reverts commit 4bf4027.
|
cc: @zwarm Pinging you so that you are aware of this change |
Generated by 🚫 dangerJS |
|
Hey @zwarm I am adding you as a reviewer since Chris is not available for the review. The IOS PR for these changes is wordpress-mobile/WordPress-iOS#22325 The haptics for the nav bar items were already in a past PR. |
zwarm
left a comment
There was a problem hiding this comment.
@AjeshRPai - I've tested the following
✅ Verify that the icons on the bottom bar as in the design
✅ Verify new tab icons adapt to environment (light vs dark)
🟡 Verify the icons animate when switching tabs
✅ Verify the me icon gets blacked out when not selected
✅ Verify notification icon shows the correct badge color when there are unread notifications (blue for WP, green for JP) - I had to turn notifications on to see the badge.
🟡 Verify the icons animate when switching tabs
- Technically it works; however it doesn't feel clean - sometimes the animation takes too long and the icon completely disappears. And sometimes in dark mode you don't see the animation at all. See my attached video. Pixel 5 Android 14
I am going to leave this PR in request changes status to give you a chance to respond. If this is the expected behavior, then I will go ahead and approve the PR. lmk. Thanks
screen-20240105-075306.mp4
zwarm
left a comment
There was a problem hiding this comment.
After syncing with @AjeshRPai , this PR will be merged and we'll take up any minor issues during beta week.


Fixes #
Description
Updates the icons in bottom bar nav in JP/WP app
Sets the me icon to B&W or with color depending on the selected state
me_icon_tint.webm
Adds a pop animation to the bottom nav icon on selecting
Note: please ignore the badge position on notification icon. It has been moved to left of the icon as before
Screen_recording_20240103_232835.webm
To Test:
Regression Notes
Potential unintended areas of impact
Bottom bar icons are not correct
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: