Bottom tab improvements: new icons, haptic feedback, icon animation - #22325
Merged
Conversation
13 tasks
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22325-01fdd40 | |
| Version | 23.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 01fdd40 | |
| App Center Build | WPiOS - One-Offs #8329 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22325-01fdd40 | |
| Version | 23.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 01fdd40 | |
| App Center Build | jetpack-installable-builds #7352 |
12 tasks
kean
requested changes
Jan 5, 2024
| UITabBar.appearance().unselectedItemTintColor = .tabUnselected | ||
|
|
||
| let appearance = UITabBarAppearance() | ||
| appearance.configureWithOpaqueBackground() |
Contributor
There was a problem hiding this comment.
| self.makeReaderTabView = readerTabViewFactory | ||
| super.init(nibName: nil, bundle: nil) | ||
|
|
||
| extendedLayoutIncludesOpaqueBars = true |
Contributor
There was a problem hiding this comment.
The reader scroll view seems to have incorrect insets. I'm leaving the comment in this file, but it's not necessarily because of the extendedLayoutIncludesOpaqueBars.
reader-1.mp4
I also tested the behavior in trunk for comparison:
reader-2.mp4
Generated by 🚫 dangerJS |
momo-ozawa
force-pushed
the
task/new-tab-icons-2
branch
from
January 5, 2024 14:44
4995816 to
01fdd40
Compare
Contributor
Generated by 🚫 Danger |
kean
self-requested a review
January 5, 2024 15:36
kean
approved these changes
Jan 5, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Updates tab bar to use native transparent styling with a blur effectAfter discussions with @kean I've decided to leave out this change since it has the potential to break many screens. I've created a new issue for tackling transparent nav bars / tab bars here: Change nav bar / tab bar appearance #22334How to test
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-03.at.16.12.56.mp4
Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: