Skip to content

Modified remaining services to use WordPressKit locale handling - #11127

Merged
4 commits merged into
developfrom
issue/wpkit-86-integration
Feb 26, 2019
Merged

Modified remaining services to use WordPressKit locale handling#11127
4 commits merged into
developfrom
issue/wpkit-86-integration

Conversation

@ghost

@ghost ghost commented Feb 22, 2019

Copy link
Copy Markdown

Supports the resolution of this issue in WordPressKit.

I've designated this a Draft PR, unless or until the associated updates to WordPressAuthenticator & WordPressKit have been properly versioned.

To test:

  • Branch should build.
  • Tests should pass.
  • Existing endpoints should work.
  • Modified endpoints should also work without regression.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@ghost ghost added this to the 12.0 milestone Feb 22, 2019
@ghost ghost self-assigned this Feb 22, 2019
@ghost
ghost requested a review from aerych February 22, 2019 23:07
@ghost

ghost commented Feb 22, 2019

Copy link
Copy Markdown
Author

@aerych would you able to spare some time to review this next week? I'd like to merge it early in the v12.0 release sequencing to ensure we have time to catch regressions.

@ghost
ghost force-pushed the issue/wpkit-86-integration branch from a9224a0 to 1d6c6fe Compare February 25, 2019 16:53
@ghost
ghost force-pushed the issue/wpkit-86-integration branch from 1d6c6fe to d6c3c03 Compare February 25, 2019 19:00

@aerych aerych left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost
ghost marked this pull request as ready for review February 26, 2019 05:47
@ghost
ghost merged commit efc96f0 into develop Feb 26, 2019
@ghost
ghost deleted the issue/wpkit-86-integration branch February 26, 2019 06:21
SergioEstevao pushed a commit that referenced this pull request Feb 27, 2019
…ation

Modified remaining services to use WordPressKit locale handling
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants