This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Modified existing services to leverage locale handling - #103
Merged
7 commits merged intoFeb 26, 2019
Merged
Conversation
Author
|
@aerych would you able to spare some time to review this next week? I'd like to merge it early in the v12.0 release sequencing to ensure we have time to catch regressions. |
ghost
requested a review
from aerych
February 22, 2019 23:11
ghost
mentioned this pull request
1 task
aerych
approved these changes
Feb 25, 2019
Contributor
There was a problem hiding this comment.
Heya @stevebaranski!
Changes look good to me :)
Just to surface our Slack chat here, we spotted an issue when passing nil for parameters that causes the locale to not be appended, but that's unrelated to the changes in this PR. 
when ready.
ghost
deleted the
issue/86-explicit-locale-handling
branch
February 26, 2019 05:15
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #86.
WordPressComRestApihas included support for implicitly passing locale in requests. WPCOM API expectslocalefor v1 endpoints &_localefor v2 endpoints, as perp77Llu-byF-p2.Testing Details
The branch should build and tests should pass.
This
WordPressAuthenticatorbranch should also pass :issue/wpkit-86-integrationThis
WPiOSbranch should also pass muster :issue/wpkit-86-integration, can be used to "smoke test" the impacted endpoints.Please check here if your pull request includes additional test coverage.