Switch over showing/fetching Streak data to new architecture - #11129
Merged
Conversation
Contributor
|
Hey @jklausa - looks like there's some data missing. This is from
This is your branch: Mar - June have no data, and July has partial. Not sure where the problem lies, so I'll refrain from taking any action on the accompanying WPKit PR until you take a look. |
ScoutHarris
approved these changes
Feb 25, 2019
ScoutHarris
left a comment
ScoutHarris
left a comment
Contributor
There was a problem hiding this comment.
Once I got pods to cooperate, the data looks accurate. Bonus points for the models looking much cleaner with your changes! 🎉
1 task
Contributor
Author
|
argh i didn't want to merge this yet |
Contributor
Author
|
my cat literally walked on my keyboard to do it, I wish i were making it up... |
Contributor
Author
|
it's fine though, tests passed so it should be g2g :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the last Insight that was using the old architecture/backend. Now all of them are powered by the new data layer :)
Note: I noticed (present also in current implementation) problem with displaying the graph for sites with extremely heavy posting traffic (like our team P2, for example). I filed a bug in WPKit and will fix it next week.fixed it upstream in WPKit already: wordpress-mobile/WordPressKit-iOS#107To test:
Verify the app builds
Verify the data shown for Streaks in stats insights is the same as above
Update release notes:
RELEASE-NOTES.txt.