This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Stats: Streaks improvements - #107
Merged
Merged
Conversation
Merged
1 task
ScoutHarris
approved these changes
Feb 25, 2019
ScoutHarris
left a comment
ScoutHarris
left a comment
Contributor
There was a problem hiding this comment.
Tested with the WPiOS PR. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #104 and changes the external API to make wordpress-mobile/WordPress-iOS#11129 possible
Testing Details
Verify the lib builds
Verify the tests pass
Check out corresponding WPiOS build and verify that the Streak data for the past year for Hogwarts P2 shows up correctly