Skip to content

Fixes Share Extension presentation bugs - #13146

Merged
bjtitus merged 5 commits into
developfrom
issue/share-extension-presentation-bugs
Dec 19, 2019
Merged

Fixes Share Extension presentation bugs#13146
bjtitus merged 5 commits into
developfrom
issue/share-extension-presentation-bugs

Conversation

@bjtitus

@bjtitus bjtitus commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

Fixes #13077
Fixes #13074

  • Merges the contents of MainDraftActionViewController into MainShareViewController and switches based on their bundle identifier.
  • Fixes the color of the navigation bar so that buttons are visible
  • Fixes modal presentation style so that the extra background space on iOS 13 is removed
  • Fixes constrained spacing issue on iPad OS 13

iPad OS 13 Draft Extension
iPad iOS 13 Draft

iOS 13 Draft Extension

To test:

  • Share content using the Drafts Action extension

PR submission checklist:

  • I have considered adding unit tests where possible. UI changes that we don't have tests for

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@bjtitus bjtitus added this to the 14.0 milestone Dec 19, 2019
@bjtitus
bjtitus requested a review from ScoutHarris December 19, 2019 18:26
@bjtitus bjtitus self-assigned this Dec 19, 2019
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Dec 19, 2019

Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

@bjtitus

bjtitus commented Dec 19, 2019

Copy link
Copy Markdown
Contributor Author

@ScoutHarris Should I add release notes to something like this? It seems like maybe I should but I thought I'd check first.

@ScoutHarris

Copy link
Copy Markdown
Contributor

Hey @bjtitus . I would. Especially since #13077 seems like it would have been quite noticeable.

@ScoutHarris ScoutHarris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good!

:shipit:

@bjtitus
bjtitus merged commit 2b91068 into develop Dec 19, 2019
@bjtitus
bjtitus deleted the issue/share-extension-presentation-bugs branch December 20, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS 13] Save as Draft share extension is unusable on iPad Save as Draft: button text is barely visible

2 participants