Update WordPressKit & WordPressAuthenticator to use the latest versions - #13641
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
ScoutHarris
approved these changes
Mar 12, 2020
ScoutHarris
left a comment
Contributor
There was a problem hiding this comment.
✅ rake dependencies
✅ run & build the app
✅ If testing in Xcode, set a breakpoint in ActivityServiceRemote, L49
✅ Unit Tests
Gio2018
approved these changes
Mar 13, 2020
Gio2018
left a comment
Contributor
There was a problem hiding this comment.
Did steps 1-6 and all worked. Looks very good!!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # n/a
To test:
rake dependenciesDo not merge until:
4.6.0-beta.6✔️1.11.0-beta.6✔️PR submission checklist:
RELEASE-NOTES.txtif necessary.