Skip to content

Update NSURL+IDN version to 0.4 - #13644

Merged
Gio2018 merged 3 commits into
developfrom
feature/Update-dependency-NSURL+IDN-v0.4
Mar 13, 2020
Merged

Update NSURL+IDN version to 0.4#13644
Gio2018 merged 3 commits into
developfrom
feature/Update-dependency-NSURL+IDN-v0.4

Conversation

@Gio2018

@Gio2018 Gio2018 commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

To test:

  • install dependencies
  • verify that build/run are successful

Note: do not merge before the new version of WordPressAuthenticator is published

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Gio2018 Gio2018 added this to the 14.5 milestone Mar 12, 2020
@Gio2018
Gio2018 requested a review from mindgraffiti March 12, 2020 23:41
@Gio2018 Gio2018 self-assigned this Mar 12, 2020
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Mar 12, 2020

Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

@Gio2018 Gio2018 changed the title Update Podfile, update NSURL+IDN version to 0.4 Update NSURL+IDN version to 0.4 Mar 12, 2020

@mindgraffiti mindgraffiti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

✅ no errors during rake dependencies
✅ build & run without issues

@Gio2018
Gio2018 merged commit 9cf9690 into develop Mar 13, 2020
@Gio2018
Gio2018 deleted the feature/Update-dependency-NSURL+IDN-v0.4 branch March 13, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants