Update screenshot test with new mocks - #15055
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
@rachelmcr, the first thing I ran across was that the image from the Editor screenshot is missing |
|
We currently don't mock the requests for media files, so likely the file wasn't loaded fast enough during your run. I confirmed that it loaded and appeared in the screenshots when I generated them. Since it worked well on my end I thought we wouldn't need anything extra for that screenshot, but to avoid that flakiness I've added I still need to resolve the Podfile.lock conflict, but I also need to update the two pod references that this PR depends on, so I'll plan to take care of that once those PRs are merged and the new pods are available. |
|
@startuptester Ok, pods are updated, conflicts resolved, and this is ready for another review! |
startuptester
left a comment
There was a problem hiding this comment.
Ran script again in Spanish after merging of the two associated PRs. Ran without error and screenshots look good!
💯

Updates the screenshot test with new mock data for new app store screenshots.
Notable changes:
Note: We're aiming to use the new screenshots with the 15.9 release, but I'm targeting
developbecause we don't expect any significant UI differences between therelease/15.9anddevelopbranches.Screenshots
Sample iPad screenshots:
Sample iPhone screenshots:
To test:
rake mocksto start the mock server.cd Scripts/fastlane.bundle exec fastlane screenshotsfor a full set in all languages (this takes a while) or e.g.bundle exec fastlane screenshots language:"es-ES"for a set of screenshots in a single non-English language to confirm it works for all targeted devices regardless of language.Before merge
PR submission checklist:
RELEASE-NOTES.txtif necessary.