Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Update screenshot mocks - #20

Merged
startuptester merged 6 commits into
developfrom
update/mocks-for-screenshots
Oct 7, 2020
Merged

Update screenshot mocks#20
startuptester merged 6 commits into
developfrom
update/mocks-for-screenshots

Conversation

@rachelmcr

@rachelmcr rachelmcr commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

Proposed Changes

This updates the mocks for new iOS app store screenshots.

Significant changes:

  • New sites introduced in the mocks (new primary site and two additional sites)
  • Modified some mocks to return the same response regardless of site (where it doesn't matter for the tests or screenshots)

To Test

Ensure all UI tests pass and screenshots are generated with expected mock data on this PR: wordpress-mobile/WordPress-iOS#15055

@rachelmcr rachelmcr added the enhancement New feature or request label Oct 6, 2020
@rachelmcr
rachelmcr marked this pull request as ready for review October 6, 2020 12:42

@startuptester startuptester left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@startuptester
startuptester merged commit c6eaf9f into develop Oct 7, 2020
@startuptester
startuptester deleted the update/mocks-for-screenshots branch October 7, 2020 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants