Fix screenshot test for Russian & Thai - #15099
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
I see there's a Podfile.lock conflict; I'll fix that once the mocks PR is merged and I update the Podfile to use the published pod. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
jkmassel
left a comment
There was a problem hiding this comment.
I left a note about a small change for your consideration.
I tested in English, Russian, and Thai.
English worked the first time; but for whatever reason Russian and Thai both failed the first time but worked on subsequent runs.
Additionally, it doesn't seem to work on iOS 14, just on 13.5.
I don't think either of these things are blockers – snapshot will auto-retry if there's a failure so worst-case the generation just takes slightly longer.
|
Thanks for the review!
Yeah, if it failed on the paste action I'm not too surprised because it was pretty flaky when I was trying it out. It's the most straightforward workaround I came up with for now but we can think about more stable options to try (maybe using language-specific text so we can type instead of paste).
Good point. We haven't made any changes for tests to run on iOS 14 but it's on my radar. Agreed that it isn't a blocker for this but I'll see if I can follow up on it soon. I made the changes mentioned above (the suggested change to the paste implementation and updated the WordPressMocks pod) so I'll go ahead and merge this PR once tests are passing. |
Generated by 🚫 dangerJS |
Fixes #15074
As noted in the issue, for some reason typing text works in most text fields and languages except secure text entry fields in Russian and Thai (of the languages we run the test in).
That issue prevented the test from logging in when the device is set to those languages. To work around that, this PR checks the language code on the device and pastes (instead of typing) the password in those languages. I didn't switch to using a paste method for all languages because in repeated test runs I found pasting to be a bit flaky, so this limits it to the languages where it's really needed.
We also have a small mocks improvement in wordpress-mobile/WordPressMocks#21 so I've updated the Podfile here so we can test that change.
To test:
rake mocks.(You can run the test at least once on an iPad Pro, 12.9 inch, 2nd or 3rd gen to test the mocks change.)
PR submission checklist:
RELEASE-NOTES.txtif necessary.