This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Add more media for media library screenshots - #21
Merged
Conversation
3 tasks
rachelmcr
marked this pull request as ready for review
October 14, 2020 15:26
jkmassel
self-requested a review
October 14, 2020 16:15
jkmassel
approved these changes
Oct 14, 2020
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
Confirmed to work as part of wordpress-mobile/WordPress-iOS#15099
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update the
mediaendpoint mock to include more media, so the media library looks full in iPad screenshots.Notice that in the Before screenshot below, in the very last row of the media library images there's a blank spot. This fixes that so the last row is entirely full.
To Test