-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Initial changes to make the Today Home Widget customizable. #15397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diegoreymendez
merged 30 commits into
feature/ios-14-today-widget
from
try/customizable-today-widget
Dec 2, 2020
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
06f4e54
WIP
diegoreymendez fe1093d
Merges the latest from the feature branch.
diegoreymendez 99b9cbe
rake lint:autocorrect
diegoreymendez 71e519d
Fixes a build issue.
diegoreymendez 5d8b9f3
Added provisioning profiles and code to show sites in the Home widget…
diegoreymendez f469151
Added several configuration schemes.
diegoreymendez c31e463
Set up Intents Signing
jkmassel 1b524e6
Adding images to the site selection in the home widget.
diegoreymendez f2f6217
Removes some unnecessary comments.
diegoreymendez 425c789
Adds some improvements.
diegoreymendez b02efc8
Some formatting cleanup.
diegoreymendez d855636
Shows the selected site in the widget.
diegoreymendez 68ab868
rake lint:autocorrect
diegoreymendez 829b282
Merges the latest from the feature branch.
diegoreymendez 8819f6d
Fixes all current merge conflicts.
diegoreymendez 898a4d5
Rolls back some unnecessary changes.
diegoreymendez 285fdb3
Merges the latest from the feature branch.
diegoreymendez 03bfa14
Rolls back the undesired changes to Info.plist.
diegoreymendez 218448e
Removed some no-longer-necessary comments.
diegoreymendez 91cf971
Updates a comment. Changed the name of a file that was unclear.
diegoreymendez 3d80962
Removed the WordPressIntentsUI target, since it wasn't being used.
diegoreymendez aced350
Unshared several schemes that were shared for no-known reasons.
diegoreymendez 42e6e37
Updates the fastlane FastFile to remove a target that doesn't exist a…
diegoreymendez b385948
Moves the default site logic to the intents extension.
diegoreymendez 7c097e2
Handles the default site through the intents extension.
diegoreymendez 20bdefe
Manually merges some changes to WordPressHomeWidgetToday that had bee…
diegoreymendez 0ad58a9
Removes an unnecessary todo.
diegoreymendez 4276aa7
Removed images from the widget site picker. Added domain as subtitle.
diegoreymendez 8266991
Fixes the indentation of some lines of code.
diegoreymendez a5b2a22
Removes some commented out code.
diegoreymendez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -529,4 +529,4 @@ + (BOOL)deleteItemForUsername:(NSString *)username | |
| } | ||
|
|
||
|
|
||
| @end | ||
| @end | ||
1 change: 1 addition & 0 deletions
1
WordPress/Classes/ViewRelated/Stats/Today Widgets/Data/TodayWidgetStats.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
WordPress/Classes/ViewRelated/Stats/Today Widgets/iOS 14 Widgets/HomeWidgetCache.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
96 changes: 96 additions & 0 deletions
96
WordPress/WordPress.xcodeproj/xcshareddata/xcschemes/WordPressIntents.xcscheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Scheme | ||
| LastUpgradeVersion = "1220" | ||
| wasCreatedForAppExtension = "YES" | ||
| version = "2.0"> | ||
| <BuildAction | ||
| parallelizeBuildables = "YES" | ||
| buildImplicitDependencies = "YES"> | ||
| <BuildActionEntries> | ||
| <BuildActionEntry | ||
| buildForTesting = "YES" | ||
| buildForRunning = "YES" | ||
| buildForProfiling = "YES" | ||
| buildForArchiving = "YES" | ||
| buildForAnalyzing = "YES"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "F1F163BD25658B4D003DC13B" | ||
| BuildableName = "WordPressIntents.appex" | ||
| BlueprintName = "WordPressIntents" | ||
| ReferencedContainer = "container:WordPress.xcodeproj"> | ||
| </BuildableReference> | ||
| </BuildActionEntry> | ||
| <BuildActionEntry | ||
| buildForTesting = "YES" | ||
| buildForRunning = "YES" | ||
| buildForProfiling = "YES" | ||
| buildForArchiving = "YES" | ||
| buildForAnalyzing = "YES"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "1D6058900D05DD3D006BFB54" | ||
| BuildableName = "WordPress.app" | ||
| BlueprintName = "WordPress" | ||
| ReferencedContainer = "container:WordPress.xcodeproj"> | ||
| </BuildableReference> | ||
| </BuildActionEntry> | ||
| </BuildActionEntries> | ||
| </BuildAction> | ||
| <TestAction | ||
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| shouldUseLaunchSchemeArgsEnv = "YES"> | ||
| <Testables> | ||
| </Testables> | ||
| </TestAction> | ||
| <LaunchAction | ||
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "" | ||
| selectedLauncherIdentifier = "Xcode.IDEFoundation.Launcher.PosixSpawn" | ||
| launchStyle = "0" | ||
| askForAppToLaunch = "Yes" | ||
| useCustomWorkingDirectory = "NO" | ||
| ignoresPersistentStateOnLaunch = "NO" | ||
| debugDocumentVersioning = "YES" | ||
| debugServiceExtension = "internal" | ||
| allowLocationSimulation = "YES" | ||
| launchAutomaticallySubstyle = "2"> | ||
| <BuildableProductRunnable | ||
| runnableDebuggingMode = "0"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "1D6058900D05DD3D006BFB54" | ||
| BuildableName = "WordPress.app" | ||
| BlueprintName = "WordPress" | ||
| ReferencedContainer = "container:WordPress.xcodeproj"> | ||
| </BuildableReference> | ||
| </BuildableProductRunnable> | ||
| </LaunchAction> | ||
| <ProfileAction | ||
| buildConfiguration = "Release" | ||
| shouldUseLaunchSchemeArgsEnv = "YES" | ||
| savedToolIdentifier = "" | ||
| useCustomWorkingDirectory = "NO" | ||
| debugDocumentVersioning = "YES" | ||
| launchAutomaticallySubstyle = "2"> | ||
| <BuildableProductRunnable | ||
| runnableDebuggingMode = "0"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "1D6058900D05DD3D006BFB54" | ||
| BuildableName = "WordPress.app" | ||
| BlueprintName = "WordPress" | ||
| ReferencedContainer = "container:WordPress.xcodeproj"> | ||
| </BuildableReference> | ||
| </BuildableProductRunnable> | ||
| </ProfileAction> | ||
| <AnalyzeAction | ||
| buildConfiguration = "Debug"> | ||
| </AnalyzeAction> | ||
| <ArchiveAction | ||
| buildConfiguration = "Release" | ||
| revealArchiveInOrganizer = "YES"> | ||
| </ArchiveAction> | ||
| </Scheme> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 0 additions & 59 deletions
59
...Press/WordPressHomeWidgetToday/Supporting Files/WordPressHomeWidgetToday.intentdefinition
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folks, I'm not sure if this scheme should be shared or not. IMHO there's no reason why schemes shouldn't be shared but if either of you knows better, can you let me know?
PS: Regardless of my doubt, I still haven't shared the others on purpose. Not sure what happened there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either, although it appears we don't currently share any schemes (although it's also not in our gitignore)... @jkmassel any ideas?