Initial changes to make the Today Home Widget customizable. - #15397
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
Update: I've pushed more changes into this PR so that the site you select is shown in the widget. |
frosty
left a comment
There was a problem hiding this comment.
Functionally, this is working as expected – I was able to see my sites in the list and select one, and that selection was saved. I've left some code level comments, and I have a few other things:
- I'm not sure we need the site icon on the configuration view – particularly if a site has a longer title, we might not have space anyway 🤔
- The sites on the list don't appear to be in any specific order, and it seems to be randomized each time
- In the main app, we show the site's domain as a subtitle on the cell – is that possible here?
- Do we need the IntentsUI target for this? I was under the impression that was only for use with Siri or Maps, but I may not understand it correctly.
| <key>CFBundleExecutable</key> | ||
| <string>${EXECUTABLE_NAME}</string> | ||
| <key>CFBundleIcons~ipad</key> | ||
| <key>CFBundleIcons</key> |
There was a problem hiding this comment.
I think it's just moving items in the plist around automatically, but I'm not sure these icon changes really belong in here?
There was a problem hiding this comment.
I've rolled back all changes to this Info.plist since none of these changes done manually. I believe the one to trigger all the changes was the NSUserActivityTypes one.
I've re-tested my PR without that change and it seems to work just fine. Can I ask you to double check this @frosty ?
|
I'm temporarily converting this back to a draft and removing the reviewers, as I fix the merge issues. Please hold any reviews. |
|
The merge conflicts are resolved, but I'll keep this as draft while I address @frosty 's feedback and also check why it is that site icons are NOT loading in the site selection screen for the widget. |
|
Gio - this is ready for review. I'll be addressing @frosty 's feedback in the meanwhile. |
| @@ -0,0 +1,96 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Folks, I'm not sure if this scheme should be shared or not. IMHO there's no reason why schemes shouldn't be shared but if either of you knows better, can you let me know?
PS: Regardless of my doubt, I still haven't shared the others on purpose. Not sure what happened there!
There was a problem hiding this comment.
I'm not sure either, although it appears we don't currently share any schemes (although it's also not in our gitignore)... @jkmassel any ideas?
|
Just for context, the rendering issue in the main Widget customization screen seems to be a bug.
|
|
This is ready for a full review. Please make sure to test the Widget is updating properly, following the steps described here. |
|
Replying to @frosty :
I just removed the images for now since I couldn't fix the bug you reported. It seems to be an SDK bug.
Will work on this in another PR. We also have to remove the hidden sites.
Done.
Removed. |
Gio2018
left a comment
There was a problem hiding this comment.
Looks good to me! I installed the widget, chose different sites and observed stats updating for that site either when the app received new stats or when the widget refreshed the timeline (had to tweak the refresh interval for that).
just left a few minor comments in the code, otherwise
!
|
Hey @frosty , @Gio2018 - Since this is targetting a feature branch and Giorgio already approved, I'm moving ahead to merge. Please feel free to add comments on this PR and I'll address them in a separate PR. @jkmassel - Please let me know what you think about this: #15397 (comment) |

First attempt at making our Today Home Widget customizable.
In this PR you can:
This PR also adds a new target (the Intents Extension) together with provisioning profiles and App ID.
About the number of lines changed:
The PR is quite large, with around 2000 lines added. Most of these, though, are changes to add the new intents target and the certificates. The code changes aren't that many.
Known limitations:
To test:
Make sure the site you selected is properly loaded in the widget.
PR submission checklist:
RELEASE-NOTES.txtif necessary.