Skip to content

Use feature flag instead of ExPlat for land in the editor - #18189

Merged
antonis merged 1 commit into
trunkfrom
feature/remove-land-in-the-editor-experiment
Mar 28, 2022
Merged

Use feature flag instead of ExPlat for land in the editor#18189
antonis merged 1 commit into
trunkfrom
feature/remove-land-in-the-editor-experiment

Conversation

@mkevins

@mkevins mkevins commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

Description

This PR replaces the Land on the editor ExPlat experiment with a development feature flag. This is needed to avoid pinging the ExPlat server now that the experiment is finished

To test:

Use the test cases of the A/B test landing in the editor PR verifying that:

  • when the landInTheEditor flag is disabled the control flow applies
  • when the landInTheEditor flag is enabled the treatment flow applies

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot

wpmobilebot commented Mar 23, 2022

Copy link
Copy Markdown
Contributor
You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18189-9d864f0. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented Mar 23, 2022

Copy link
Copy Markdown
Contributor
You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18189-9d864f0. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@mkevins
mkevins requested a review from antonis March 28, 2022 05:44
@mkevins
mkevins marked this pull request as ready for review March 28, 2022 05:45
@mkevins mkevins added this to the 19.6 milestone Mar 28, 2022
@mkevins

mkevins commented Mar 28, 2022

Copy link
Copy Markdown
Contributor Author

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary

I believe this should not be user-facing, since the experiment has ended. If this assumption is not valid, a release note should be added before merging.

@antonis antonis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for tackling this @mkevins 🙇
I tested the app and it works as expected. The code changes also look good 🎉

@antonis
antonis merged commit b2a55ff into trunk Mar 28, 2022
@antonis
antonis deleted the feature/remove-land-in-the-editor-experiment branch March 28, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants