Skip to content

Blogging Prompts Dashboard Card: don't show remove menu item. - #18627

Merged
ScoutHarris merged 1 commit into
trunkfrom
feature/18429-disable_remove_from_dashboard
May 17, 2022
Merged

Blogging Prompts Dashboard Card: don't show remove menu item.#18627
ScoutHarris merged 1 commit into
trunkfrom
feature/18429-disable_remove_from_dashboard

Conversation

@ScoutHarris

Copy link
Copy Markdown
Contributor

Ref: #18429, #18250, p1652262324746539-slack-C01CW1VMLAF

Per the referenced Slack conversation, the Remove from dashboard option on the dashboard prompt card is removed as it probably won't be implemented for V1.

To test:

  • Run on an iOS 14+ device.
  • Go to My Site > Home > Prompts.
  • Tap on the ellipsis menu.
  • Verify Remove from dashboard does not appear.
  • Repeat on an iOS 13 device.
iOS 15 Before iOS 15 After
15_before 15_after
iOS 13 Before iOS 13 After
13_before 13_after

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 20.0 milestone May 16, 2022
@ScoutHarris ScoutHarris self-assigned this May 16, 2022
@ScoutHarris
ScoutHarris requested a review from dvdchr May 16, 2022 20:18
@ScoutHarris
ScoutHarris marked this pull request as ready for review May 16, 2022 20:18
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18627-377da1e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18627-377da1e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@dvdchr dvdchr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in both iOS 15 and 13. LGTM. The remove button is removed! :shipit:

@ScoutHarris

Copy link
Copy Markdown
Contributor Author

Thanks @dvdchr !

@ScoutHarris
ScoutHarris merged commit f2ca60c into trunk May 17, 2022
@ScoutHarris
ScoutHarris deleted the feature/18429-disable_remove_from_dashboard branch May 17, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants