Skip to content

Blogging Prompts Dashboard Card: don't show remove menu item. #18627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScoutHarris merged 1 commit into from
May 17, 2022
Merged

Blogging Prompts Dashboard Card: don't show remove menu item. #18627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions ...ress/Classes/ViewRelated/Blog/Blog Dashboard/Cards/Prompts/DashboardPromptsCardCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ class DashboardPromptsCardCell: UICollectionViewCell, Reusable {
}
}

// This provides a quick way to toggle the `Remove from dashboard` menu item.
// Since it (probably) will not be included in Blogging Prompts V1, it is disabled by default.
private let removeFromDashboardEnabled = false

// Used to present:
// - The menu sheet for contextual menu in iOS13.
// - The Blogging Prompts list when selected from the contextual menu.
Expand Down Expand Up @@ -273,15 +277,16 @@ class DashboardPromptsCardCell: UICollectionViewCell, Reusable {

// Defines the structure of the contextual menu items.
private var contextMenuItems: [[MenuItem]] {
return [
[
.viewMore(viewMoreMenuTapped),
.skip(skipMenuTapped)
],
[
.remove(removeMenuTapped)
]
let defaultItems: [MenuItem] = [
.viewMore(viewMoreMenuTapped),
.skip(skipMenuTapped)
]

if removeFromDashboardEnabled {
return [defaultItems, [.remove(removeMenuTapped)]]
}

return [defaultItems]
}

private var contextMenu: UIMenu {
Expand Down