Demo PR for using reverse-DNS notation for "Dismiss" localized strings - #19029
Closed
mokagio wants to merge 5 commits into
Closed
Demo PR for using reverse-DNS notation for "Dismiss" localized strings#19029mokagio wants to merge 5 commits into
mokagio wants to merge 5 commits into
Conversation
Generated by 🚫 dangerJS |
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
AliSoftware
reviewed
Jul 12, 2022
AliSoftware
left a comment
AliSoftware
left a comment
Contributor
There was a problem hiding this comment.
I know that's just a demo PR to show just a single example, so unlikely to be committed as is, but just wanted to make sure we wouldn't accidentally commit a typo, in case this PR evolved from Draft/demo to become the real PR fixing all other cases and end up landing in trunk
| let message = NSLocalizedString("Your media could not be exported. If the problem persists you can contact us via the Me > Help & Support screen.", comment: "Error message when picked media cannot be imported into stories.") | ||
| let dismissTitle = NSLocalizedString( | ||
| "mediaPicker.failedMediaExportAlert.dismissButton", | ||
| value: "Dimiss", |
Contributor
There was a problem hiding this comment.
Suggested change
| value: "Dimiss", | |
| value: "Dismiss", |
😉
Contributor
Author
|
Closing in favor of #19136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #19028.
Notice that the first commit is there only to establish a baseline for
.strings, so that the diff in the final commit only shows the changes due to the new "Dismiss" keys added here.