Use reverse-DNS keys syntax to disambiguate "Dismiss" translations – 1 of many#19136
Merged
Conversation
mokagio
commented
Aug 2, 2022
| @objc lazy var closeButton: UIBarButtonItem = { | ||
| let button = UIBarButtonItem(image: .gridicon(.cross), style: .plain, target: self, action: #selector(WebKitViewController.close)) | ||
| button.title = NSLocalizedString("Dismiss", comment: "Dismiss a view. Verb") | ||
| button.title = NSLocalizedString("webKit.button.dismiss", value: "Dismiss", comment: "Verb. Dismiss the web view screen.") |
Contributor
Author
There was a problem hiding this comment.
I update the comment too here because now the string is specialized to WebKitViewController.
mokagio
commented
Aug 2, 2022
| } | ||
|
|
||
| //Dimiss the fullscreen view, once it has fully closed process the saving if needed | ||
| // Dismiss the fullscreen view, once it has fully closed process the saving if needed |
Contributor
Author
There was a problem hiding this comment.
Bumped into this while looking for typos in "dismiss". It's just a comment, but it was useful to fix it so it didn't add noise to the search results.
momo-ozawa
approved these changes
Aug 2, 2022
Notice that there are other two instances of "Dismiss" in this class. I haven't updated them because they weren't localized to begin with. They come from the stories feature, which I guess was integrated as an experiment?
mokagio
force-pushed
the
use-reverse-dns-for-dismiss-keys
branch
from
August 3, 2022 04:49
5dfae85 to
73081ec
Compare
mokagio
enabled auto-merge
August 3, 2022 04:49
Contributor
Author
|
I forced pushed with a different commit message, one not using backticks, to hopefully get CI to pass. Sorry for the spam. |
mokagio
force-pushed
the
use-reverse-dns-for-dismiss-keys
branch
from
August 3, 2022 04:51
73081ec to
1b7699a
Compare
…ViewController` Notice I also updated the comment. I started with removing the `AlertView` reference, because that's an implementation detail that should be irrelevant for translators. Replacing it with 'alert view' seemed too generic, so I added more explanation.
mokagio
force-pushed
the
use-reverse-dns-for-dismiss-keys
branch
from
August 3, 2022 05:00
1b7699a to
0b8f113
Compare
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #19028 for details on why we ought to use reverse-DNS keys in this particular instance, but also moving forward.
Notice the title says "1 of many". This PR does not address all "Dismiss" instance but I decided to open a PR with what I got so far to avoid having diffs that are too big.
@momo-ozawa @dvdchr I asked for your review as per GitHub suggestion.
Regression Notes
RELEASE-NOTES.txtif necessary. N.A.