Skip to content

[Draft] Jetpack Focus: Enable iOS13 Widgets for Jetpack - #19490

Closed
staskus wants to merge 4 commits into
fix/19460-jetpack-focus-enable-widgets-for-jetpackfrom
task/19460-jetpack-focus-enable-ios13-widgets-for-jetpack
Closed

[Draft] Jetpack Focus: Enable iOS13 Widgets for Jetpack#19490
staskus wants to merge 4 commits into
fix/19460-jetpack-focus-enable-widgets-for-jetpackfrom
task/19460-jetpack-focus-enable-ios13-widgets-for-jetpack

Conversation

@staskus

@staskus staskus commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Depends on #19479

Description

Enable iOS13 Today, ThisWeek and AllTime Widgets.

Using the same approach as #19479 to enable them

Testing instructions

Case 1: Fresh install

  1. Install Jetpack on iOS13
  2. Scroll sideways to Widget Screen
  3. Add Today, This Week, This Year widgets - they should be showing Stats for the default site
  4. Click on the widgets - they should open Jetpack app and take to Stats screen
  5. Come back to the app and logout - the widget should be showing message adapted for Jetpack

Case 2: WordPress app with widgets exist

  1. Install WordPress on iOS13, log in and add widgets
  2. Install Jetpack, log in to a different account and add widgets
  3. Jetpack app should be showing different information to WordPress app

Case 3: Old Version - New Version

  1. Install an older version of Jetpack on iOS and log in
  2. Install and launch a new version of Jetpack
  3. Add widgets, they should work in all the scenarios as in Case 1

Regression Notes

  1. Potential unintended areas of impact

Current iOS13 widgets functionality WordPress

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • I have completed the Regression Notes.
    Those can be shared with Jetpack Focus: Enable iOS14+ Stats Widgets and Intents for Jetpack #19479
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Images & Videos

image

Simulator Screen Shot - iPhone 8 - 2022-10-20 at 15 02 52

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Oct 20, 2022

Copy link
Copy Markdown
Fails
🚫

This PR is tagged with '[Status] DO NOT MERGE' label.

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot

wpmobilebot commented Oct 20, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19490-15c206c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio

mokagio commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Taking the liberty of adding "Do not merge" to this PR because we are considering removing iOS 13 support from the apps. If that goes through, no additional work should be done here, and we should close this instead.

Internal ref pcdRpT-19n-p2#comment-1511

@staskus

staskus commented Oct 25, 2022

Copy link
Copy Markdown
Contributor Author

Closing in favor of Bump iOS deployment target from 13.0 to 14.0

@staskus staskus closed this Oct 25, 2022
@mokagio
mokagio deleted the task/19460-jetpack-focus-enable-ios13-widgets-for-jetpack branch October 27, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants