Bump iOS deployment target from 13.0 to 14.0 by mokagio · Pull Request #19496 · wordpress-mobile/WordPress-iOS

mokagio · 2022-10-21T08:59:31Z

Bump iOS deployment target from 13.0 to 14.0.

To test

The app should build locally. Ideally, there should be no deprecation warnings or errors.

Currently, we have a bunch of errors due to "Today View extensions have been deprecated". The reason we have an error and not a warning is because those targets have "Treat Warnings as Errors" set to YES. Update: #19509 addressed those.

See Today View errors

Regression Notes

Potential unintended areas of impact – N.A.
What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
What automated tests I added (or what prevented me from doing so) – N.A.

I have completed the Regression Notes.
I have considered adding unit tests for my changes. N.A.
I have considered adding accessibility improvements for my changes. N.A.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

staskus · 2022-10-24T13:09:16Z

All iOS13 widget targets WordPressAllTimeWidget, WordPressThisWeekWidget, WordPressTodayWidget can be removed since we have iOS14+ WordPressStatsWidgets as a replacement.

guarani · 2022-10-24T19:41:46Z

If there are no objections to dropping iOS 13 support and it's possible to merge this PR by Friday, we could:

Target v21.1 with this PR
Remove ~~Home~~ Today View widgets in this PR to remove the errors
Rebase Jetpack Focus: Enable iOS14+ Stats Widgets and Intents for Jetpack #19479 (which also targets 21.1) onto this branch
Close [Draft] Jetpack Focus: Enable iOS13 Widgets for Jetpack #19490

From your side @mokagio, does this seem like a viable approach?
If it's not possible to merge this by Friday this week (e.g. if there are more errors to fix), we may have to support iOS 13 widgets on Jetpack until this PR is merged.
Wdyt @staskus? Are there better alternatives?

mokagio · 2022-10-25T04:06:51Z

@guarani yes sounds good. I started working on this (mokagio/remove-ios-13-widgets) and was aiming to get it done today, but I need to drop off unexpectedly. Stay tuned.

staskus · 2022-10-25T06:36:27Z

Rebase #19479 (which also targets 21.1) onto this branch

I think maybe we should merge iOS14+ to trunk and then adjust this PR branch accordingly? Widgets changes are a must for 21.1, unlike a version bump.

If it's not possible to merge this by Friday this week (e.g. if there are more errors to fix), we may have to support iOS 13 widgets on Jetpack until this PR is merged.
Wdyt @staskus? Are there better alternatives?

@guarani I don't think it makes sense to support iOS13 widgets, even if we won't manage to bump the deployment target this release. The usability of iOS13 is too low and we would be removing the changes next release either way.

mokagio · 2022-10-25T12:42:43Z

@guarani @staskus

Rebase #19479 (which also targets 21.1) onto this branch

I think maybe we should merge iOS14+ to trunk and then adjust this PR branch accordingly? Widgets changes are a must for 21.1, unlike a version bump.

The iOS 13 widget removals is ready for review, so there should be ample time for the Jetpack widgets to go on top of this.

Widgets changes are a must for 21.1

Are they? Is there an external commitment that must be met by that version? Just curious.

guarani · 2022-10-25T17:26:01Z

I think maybe we should merge iOS14+ to trunk and then adjust this PR branch accordingly? Widgets changes are a must for 21.1, unlike a version bump.

This is a good point, I think we can afford to ship iOS 14 Home Screen widgets on Jetpack, without trying to support iOS 13 Today View widgets on Jetpack as well. The only users who will benefit from iOS Today View widgets are:

At most 0.05% of current JP app users (this is the percentage of users on iOS 13, but the number is lower because not all will install widgets).
At most 0.5% of current WP users (this is the percentage of users on iOS 13 and assumes all switch to Jetpack)

Are they? Is there an external commitment that must be met by that version? Just curious.

Not an external commitment, but an internal goal for the Jetpack app to offer the same features the WordPress app offers by Nov 17. Shipping widgets on Jetpack in 21.1 contributes to this goal.

mokagio · 2022-10-26T11:42:56Z

@guarani @staskus prioritizing the Jetpack widgets sounds good to me. There are only two days left for that in my time zone by now and we'd be cutting it close any other way.

I'll wait for that to land on trunk then update everything accordingly. Let me know if there's something I can do on the Jetpack widgets end.

staskus · 2022-10-26T14:59:16Z

@mokagio Jetpack Widgets merged ✅

wpmobilebot · 2022-10-27T03:25:49Z

You can test the changes in Jetpack from this Pull Request by:

Clicking here or scanning the QR code below to access App Center
Then installing the build number pr19496-c13ed67 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

This way, all the targets will use the same iOS deployment, all coming from the project-level setting.

The class property was deprecated in iOS 14. Xcode gave the following warning (which we treat as an error): > Deprecated. Use the instance property `authorizationStatus` instead.

The deprecation warning in Xcode wasn't informative, but the deprecation annotation suggested what to do: ``` /* * locationManager:didChangeAuthorizationStatus: * * Discussion: * Invoked when the authorization status changes for this application. */ - (void)locationManager:(CLLocationManager *)manager didChangeAuthorizationStatus:(CLAuthorizationStatus)status API_DEPRECATED_WITH_REPLACEMENT("-locationManagerDidChangeAuthorization:", ios(4.2, 14.0), macos(10.7, 11.0), watchos(1.0, 7.0), tvos(9.0, 14.0)); ```

mokagio · 2022-10-28T03:20:09Z

-@available(iOS, deprecated: 14.0, message: "Use SchedulingDatePickerViewController, based on UIDatePicker.inline")
-class SchedulingCalendarViewController: UIViewController, CalendarSheet, DateCoordinatorHandler, SchedulingViewControllerProtocol {


The deprecation annotation recommends using SchedulingDatePickerViewController instead of SchedulingCalendarViewController in iOS 14 and above.

Now that we support only iOS 14 and above, this whole file can be deleted. Notice that in this file we also had CalendarSheet and TimePickerViewController.

mokagio · 2022-10-28T04:21:46Z

+// FIXME: This protocol is redundant as of dropping iOS 13.
+//
+// It was used as a facade in between `SchedulingCalendarViewController` (iOS 13) and
+// `SchedulingDatePickerViewController` (iOS 14+). `SchedulingCalendarViewController` has been
+// deleted so we can remove this as well.
 protocol SchedulingViewControllerProtocol: UIViewController, UIViewControllerTransitioningDelegate, UIAdaptivePresentationControllerDelegate {


I'll follow this up later on. I wanted to keep the scope limited.

mokagio · 2022-10-28T04:21:49Z

-
-class TimePickerViewControllerTests: XCTestCase {
-
-    var timePickerVC: TimePickerViewController?


TimePickerViewController was removed together with `

mokagio · 2022-10-28T04:23:06Z

@crazytonyli I asked for your review on this PR with failing CI because I already have #19509 which addresses the issue and has been approved. I didn't want to merge it in, otherwise the diff would have become bigger.

Let me know what you think.

crazytonyli · 2022-10-28T05:52:04Z

@mokagio Am I correct in saying that this PR is not longer needed? Can we change the target branch of #19509 from drop-ios-13 to trunk and merge it?

mokagio · 2022-10-31T01:24:19Z

Can we change the target branch of #19509 from drop-ios-13 to trunk and merge it?

Oh yes, that would do it too. I guess what I should have done was create the widgets PR from trunk. So that, once they were merged, rebasing/merging trunk into this one would have showed a green CI.

But, given that PR was based off this one, your suggestion will save us a merge. Thanks!

mokagio · 2022-10-31T01:24:48Z

Closing in favor of merging #19509 directly into trunk

mokagio mentioned this pull request Oct 21, 2022

Centralize IPHONEOS_DEPLOYMENT_TARGET setting #19495

Closed

4 tasks

mokagio changed the base branch from mokagio/extract-deployment-target to trunk October 23, 2022 11:29

staskus mentioned this pull request Oct 25, 2022

[Draft] Jetpack Focus: Enable iOS13 Widgets for Jetpack #19490

Closed

4 tasks

This was referenced Oct 25, 2022

Remove redundant #available(iOS 12, *) checks #19511

Merged

Remove redundant #available(iOS 13, *) checks #19513

Closed

Remove iOS 13 Widgets #19509

Merged

mokagio force-pushed the drop-ios-13 branch from fc0853d to 30f02ee Compare October 27, 2022 01:58

mokagio added 7 commits October 28, 2022 13:39

Remove target-level IPHONEOS_DEPLOYMENT_TARGET setting

a7bc5e9

This way, all the targets will use the same iOS deployment, all coming from the project-level setting.

Extract IPHONEOS_DEPLOYMENT_TARGET to SDKVersions.xcconfig

84f07d2

Bump IPHONEOS_DEPLOYMENT_TARGET from 13.0 to 14.0

148fe3d

Add RELEASE-NOTES.txt entry for dropping iOS 13

123bfcd

Use CLLocationManager instance property for authorizationStatus

9cdff34

The class property was deprecated in iOS 14. Xcode gave the following warning (which we treat as an error): > Deprecated. Use the instance property `authorizationStatus` instead.

Remove iOS 13 only SchedulingCalendarViewController

c13ed67

mokagio force-pushed the drop-ios-13 branch from 193b8b5 to c13ed67 Compare October 28, 2022 02:40

mokagio marked this pull request as ready for review October 28, 2022 02:40

mokagio added this to the 21.1 milestone Oct 28, 2022

mokagio self-assigned this Oct 28, 2022

mokagio requested a review from crazytonyli October 28, 2022 03:17

mokagio commented Oct 28, 2022

View reviewed changes

mokagio closed this Oct 31, 2022

mokagio deleted the drop-ios-13 branch December 2, 2022 06:06

		@available(iOS, deprecated: 14.0, message: "Use SchedulingDatePickerViewController, based on UIDatePicker.inline")
		class SchedulingCalendarViewController: UIViewController, CalendarSheet, DateCoordinatorHandler, SchedulingViewControllerProtocol {


		class TimePickerViewControllerTests: XCTestCase {

		var timePickerVC: TimePickerViewController?

Uh oh!

Conversation

mokagio commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To test

Regression Notes

Uh oh!

staskus commented Oct 24, 2022

Uh oh!

guarani commented Oct 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mokagio commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staskus commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mokagio commented Oct 25, 2022

Uh oh!

guarani commented Oct 25, 2022

Uh oh!

mokagio commented Oct 26, 2022

Uh oh!

staskus commented Oct 26, 2022

Uh oh!

wpmobilebot commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mokagio Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

mokagio Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

mokagio Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

mokagio commented Oct 28, 2022

Uh oh!

crazytonyli commented Oct 28, 2022

Uh oh!

mokagio commented Oct 31, 2022

Uh oh!

mokagio commented Oct 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mokagio commented Oct 21, 2022 •

edited

Loading

guarani commented Oct 24, 2022 •

edited

Loading

mokagio commented Oct 25, 2022 •

edited

Loading

staskus commented Oct 25, 2022 •

edited

Loading

wpmobilebot commented Oct 27, 2022 •

edited

Loading