Demo possible build error - #19502
Closed
mokagio wants to merge 2 commits into
Closed
Conversation
mokagio
changed the base branch from
trunk
to
fix/19460-jetpack-focus-enable-widgets-for-jetpack
October 24, 2022 01:29
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates a drawback of implementing shared configurations by duplicating a class implementation across targets.
It's possible to add a new configuration to the class defined in one target without adding the definition to the other.
Admittedly, our CI setup will reveal that error eventually and in the context of the PR that introduced the change. Still, we ought to find a way to make the error impossible, to avoid such a long feedback loop.