Skip to content

Demo possible build error #19502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mokagio wants to merge 2 commits into from
Closed

Demo possible build error #19502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10cd686
Remove an unnecessary `import Foundation`
mokagio Oct 24, 2022
09f690c
Update `AppConfigurationWidget` for Jetpack only to demo build failure
mokagio Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WordPress/Classes/Services/AccountService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ - (void)setupAppExtensionsWithDefaultAccount
NSNumber *todayExtensionSiteID = [sharedDefaults objectForKey:AppConfigurationWidget.statsTodayWidgetUserDefaultsSiteIdKey];
NSString *todayExtensionBlogName = [sharedDefaults objectForKey:AppConfigurationWidget.statsTodayWidgetUserDefaultsSiteNameKey];
NSString *todayExtensionBlogUrl = [sharedDefaults objectForKey:AppConfigurationWidget.statsTodayWidgetUserDefaultsSiteUrlKey];
NSString *worksInJetpackButNotInWordPress = [sharedDefaults objectForKey:AppConfigurationWidget.newValueOnlyInJetpack];

Blog *todayExtensionBlog = [Blog lookupWithID:todayExtensionSiteID in:self.managedObjectContext];
NSTimeZone *timeZone = [todayExtensionBlog timeZone];
Expand Down
1 change: 1 addition & 0 deletions WordPress/Jetpack/WidgetConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@ import Foundation
@objc static let homeWidgetTodayFilename = "JetpackHomeWidgetTodayData.plist"
@objc static let homeWidgetAllTimeFilename = "JetpackHomeWidgetAllTimeData.plist"
@objc static let homeWidgetThisWeekFilename = "JetpackHomeWidgetThisWeekData.plist"
@objc static let newValueOnlyInJetpack = "test"
}
}
2 changes: 0 additions & 2 deletions WordPress/JetpackStatsWidgets/LocalizationConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import Foundation

extension AppConfiguration.Widget {
struct Localization {
static let unconfiguredViewTodayTitle = LocalizableStrings.unconfiguredViewJetpackTodayTitle
Expand Down