[Tooling] Use Buildkite emojis for Prototype Builds - #20667
Merged
Conversation
Instead of relying on the icon URL returned by App Center API, which is a URL that contains a signed token that is only valid for a certain amount of time and thus ends up making that URL invalid and the icon image unreachable after some time has passed (e.g. when you go back on older PRs)
Generated by 🚫 dangerJS |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20667-c6495fa | |
| Version | 22.3 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c6495fa | |
| App Center Build | WPiOS - One-Offs #5693 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20667-c6495fa | |
| Version | 22.3 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c6495fa | |
| App Center Build | jetpack-installable-builds #4723 |
AliSoftware
enabled auto-merge
May 12, 2023 15:16
spencertransier
approved these changes
May 12, 2023
spencertransier
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me! ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why?
If we don't provide an explicit
app_iconto the call toprototype_build_details_commentaction, this action uses the URL of the icon returned by the App Center API as a fallback.This works well in general, except that this URL contains a signed token in its query parameter, that is only valid for a certain amount of time. Thus this ends up making that icon URL invalid (and the icon image unreachable) after some time has passed (e.g. when you go back on older PRs, like here).
How?
To fix this, we now specify the Buildkite emoji (
:wordpress:or:jetpack:) explicitly to use asapp_icon.Testing
https://raw.githubusercontent.com/buildkite/emojis/main/img-buildkite-64/*.png(instead of a URL to App Center servers with a token in query)