Skip to content

[Tooling] Use Buildkite emojis for Prototype Builds - #20667

Merged
AliSoftware merged 1 commit into
trunkfrom
tooling/fix-prototype-build-icon
May 12, 2023
Merged

[Tooling] Use Buildkite emojis for Prototype Builds#20667
AliSoftware merged 1 commit into
trunkfrom
tooling/fix-prototype-build-icon

Conversation

@AliSoftware

@AliSoftware AliSoftware commented May 12, 2023

Copy link
Copy Markdown
Contributor

Why?

If we don't provide an explicit app_icon to the call to prototype_build_details_comment action, this action uses the URL of the icon returned by the App Center API as a fallback.

This works well in general, except that this URL contains a signed token in its query parameter, that is only valid for a certain amount of time. Thus this ends up making that icon URL invalid (and the icon image unreachable) after some time has passed (e.g. when you go back on older PRs, like here).

How?

To fix this, we now specify the Buildkite emoji (:wordpress: or :jetpack:) explicitly to use as app_icon.

Testing

  • Check that the PR comments about WP and JP prototypes builds show the right icon for each case
  • Hover over the :wordpress: and :jetpack: emojis that are embedded in those comments—both for the emoji at the start of the comment before the 📲 , and the one in front of the "App Name" row—and verify that all 4 of them use a URL like https://raw.githubusercontent.com/buildkite/emojis/main/img-buildkite-64/*.png (instead of a URL to App Center servers with a token in query)
pr-20667-prototype-pr-comment-icon

Instead of relying on the icon URL returned by App Center API, which is a URL that contains a signed token that is only valid for a certain amount of time and thus ends up making that URL invalid and the icon image unreachable after some time has passed (e.g. when you go back on older PRs)
@AliSoftware AliSoftware added the Tooling Build, Release, and Validation Tools label May 12, 2023
@AliSoftware
AliSoftware requested a review from a team May 12, 2023 14:44
@AliSoftware AliSoftware self-assigned this May 12, 2023
@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20667-c6495fa
Version22.3
Bundle IDorg.wordpress.alpha
Commitc6495fa
App Center BuildWPiOS - One-Offs #5693
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20667-c6495fa
Version22.3
Bundle IDcom.jetpack.alpha
Commitc6495fa
App Center Buildjetpack-installable-builds #4723
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@AliSoftware
AliSoftware enabled auto-merge May 12, 2023 15:16

@spencertransier spencertransier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! :shipit:

@AliSoftware
AliSoftware merged commit d2eb401 into trunk May 12, 2023
@AliSoftware
AliSoftware deleted the tooling/fix-prototype-build-icon branch May 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants