Skip to content

[Tooling] Use Buildkite emojis for Prototype Builds #20667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AliSoftware merged 1 commit into from
May 12, 2023
Merged

[Tooling] Use Buildkite emojis for Prototype Builds #20667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fastlane/lanes/build.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@
scheme: 'WordPress Alpha',
output_app_name: 'WordPress Alpha',
appcenter_app_name: 'WPiOS-One-Offs',
app_icon: ':wordpress:', # Use Buildkite emoji
sentry_project_slug: SENTRY_PROJECT_SLUG_WORDPRESS
)
end
Expand All @@ -281,6 +282,7 @@
scheme: 'Jetpack',
output_app_name: 'Jetpack Alpha',
appcenter_app_name: 'jetpack-installable-builds',
app_icon: ':jetpack:', # Use Buildkite emoji
sentry_project_slug: SENTRY_PROJECT_SLUG_JETPACK
)
end
Expand Down Expand Up @@ -313,7 +315,7 @@ def generate_prototype_build_number
# Builds a Prototype Build for WordPress or Jetpack, then uploads it to App Center and comment with a link to it on the PR.
#
# rubocop:disable Metrics/AbcSize
def build_and_upload_prototype_build(scheme:, output_app_name:, appcenter_app_name:, sentry_project_slug:)
def build_and_upload_prototype_build(scheme:, output_app_name:, appcenter_app_name:, app_icon:, sentry_project_slug:)
configuration = 'Release-Alpha'

# Get the current build version, and update it if needed
Expand Down Expand Up @@ -371,6 +373,7 @@ def build_and_upload_prototype_build(scheme:, output_app_name:, appcenter_app_na
# Post PR Comment
comment_body = prototype_build_details_comment(
app_display_name: output_app_name,
app_icon: app_icon,
app_center_org_name: APPCENTER_OWNER_NAME,
metadata: { Configuration: configuration },
fold: true
Expand Down