Drop iOS 14 Support: Address UIButton API deprecations (#1) - #20897
Merged
Conversation
kean
commented
Jun 16, 2023
|
|
||
| [self.accessoryStackView addArrangedSubview:button]; | ||
| [button setContentHuggingPriority:UILayoutPriorityDefaultHigh forAxis:UILayoutConstraintAxisHorizontal]; | ||
| [button setContentHuggingPriority:UILayoutPriorityRequired forAxis:UILayoutConstraintAxisHorizontal]; |
Contributor
Author
There was a problem hiding this comment.
Not sure why hugging behavior changes with the new button configuration. I couldn't find any related documentation. I asked on Mastodon, and other folks also encountered it. The goal is to ensure the label on the right has a lower hugging priority.
kean
commented
Jun 16, 2023
| [trashButton setImage:[UIImage gridiconOfType:GridiconTypeTrash] forState:UIControlStateNormal]; | ||
| [trashButton addTarget:self action:@selector(trashButtonPressed) forControlEvents:UIControlEventTouchUpInside]; | ||
| trashButton.backgroundColor = [UIColor clearColor]; | ||
| trashButton.adjustsImageWhenHighlighted = YES; |
Contributor
Author
There was a problem hiding this comment.
This is no-op because true is the default value. (Yes, it's deprecated in iOS 15).
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20897-44943c0 | |
| Version | 22.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 44943c0 | |
| App Center Build | WPiOS - One-Offs #6025 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20897-44943c0 | |
| Version | 22.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 44943c0 | |
| App Center Build | jetpack-installable-builds #5050 |
momo-ozawa
approved these changes
Jun 19, 2023
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related Issue #20860
Replace a few places that were using deprecated UIButton APIs. Some of the code was dead, so I removed it.
To test:
Menus
Notification Comment Details
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.