Drop iOS 14 Support: Fix an issue with PostMetaButton not visible from Interface Builder - #20921
Merged
Merged
Conversation
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20921-f53369e | |
| Version | 22.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f53369e | |
| App Center Build | WPiOS - One-Offs #6058 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20921-f53369e | |
| Version | 22.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f53369e | |
| App Center Build | jetpack-installable-builds #5084 |
momo-ozawa
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related Issue #20860
I was doing regression testing for my iOS 14-related changes and found an issue in the Reader.
Turns out after changing
PostMetaButtonfrom Objective-C to Swift in #20897, it stopped being visible from the Interface Builder. In this PR, I revert this change for now until there is a better solution.Note: I enabled auto-merge to make sure it gets merge quickly
To test:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.