Skip to content

Drop iOS 14 Support: Fix an issue with PostMetaButton not visible from Interface Builder - #20921

Merged
kean merged 1 commit into
trunkfrom
task/ios-15-fix-missing-postmetabutton
Jun 21, 2023
Merged

Drop iOS 14 Support: Fix an issue with PostMetaButton not visible from Interface Builder#20921
kean merged 1 commit into
trunkfrom
task/ios-15-fix-missing-postmetabutton

Conversation

@kean

@kean kean commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Related Issue #20860

I was doing regression testing for my iOS 14-related changes and found an issue in the Reader.

Turns out after changing PostMetaButton from Objective-C to Swift in #20897, it stopped being visible from the Interface Builder. In this PR, I revert this change for now until there is a better solution.

Note: I enabled auto-merge to make sure it gets merge quickly

Screenshot 2023-06-20 at 9 23 02 PM

To test:

  • Open Reader
  • Verify that post button are displayed correctly

Regression Notes

  1. Potential unintended areas of impact: n/a
  2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jun 21, 2023
@kean
kean enabled auto-merge June 21, 2023 01:28
@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20921-f53369e
Version22.6
Bundle IDorg.wordpress.alpha
Commitf53369e
App Center BuildWPiOS - One-Offs #6058
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20921-f53369e
Version22.6
Bundle IDcom.jetpack.alpha
Commitf53369e
App Center Buildjetpack-installable-builds #5084
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean
kean merged commit ffa6f87 into trunk Jun 21, 2023
@kean
kean deleted the task/ios-15-fix-missing-postmetabutton branch June 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants