Add editorialized release notes for version 23.0#21312
Merged
Merged
Conversation
mokagio
commented
Aug 11, 2023
Comment on lines
+18
to
+19
| msgid "Jetpack – Website Builder" | ||
| msgid "Jetpack – Website Builder | ||
| " |
Contributor
Author
There was a problem hiding this comment.
🤔 I'm not sure about these changes...
This is the first time I generated the .po with release toolkit v9.0.0, but nothing in its changelog stands out as a possible cause for this.
Contributor
Author
There was a problem hiding this comment.
I'm glad with have gplint in place. I have a feeling this wasn't valid but didn't remember why. The linter confirmed it.
Contributor
Author
There was a problem hiding this comment.
but nothing in its changelog stands out as a possible cause for this.
Update: I bet it's the PR that renamed the metadata parsing files, wordpress-mobile/release-toolkit#497. The name was hidden in the "Support Ruby 3.0" umbrella.
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21312-c6d6d67 | |
| Version | 23.0 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c6d6d67 | |
| App Center Build | jetpack-installable-builds #5725 |
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21312-c6d6d67 | |
| Version | 23.0 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c6d6d67 | |
| App Center Build | WPiOS - One-Offs #6685 |
Blaze Manage Campaigns: Match colors on web
Generated by 🚫 dangerJS |
…age-aspect Blaze Manage Campaigns: Preserve image aspect for campaign thumbnail
This reverts commit c83d06dd6b74aa062ebb0cdb05d2c694b458111a. We ought to fix the problem at the root, not risk using an out of date version of the release-toolkit.
This reverts commit d5882e8. I didn't realize the commit I reverted was not the one that changed the release-toolkit version. I used HEAD~1 but there are two "update metadata" commits, so I should have used HEAD~2.
This reverts commit 295c3b3. We ought to fix the problem at the root, not risk using an out of date version of the release-toolkit.
oguzkocer
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the updated
.pofiles for GlotPress.