Remove WordPress widget and iOS 13 Today widget related code - #21521
Merged
Conversation
Generated by 🚫 dangerJS |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21521-0da1d27 | |
| Version | 23.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0da1d27 | |
| App Center Build | WPiOS - One-Offs #6989 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21521-0da1d27 | |
| Version | 23.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0da1d27 | |
| App Center Build | jetpack-installable-builds #6031 |
guarani
approved these changes
Sep 8, 2023
guarani
left a comment
Contributor
There was a problem hiding this comment.
Thanks for removing all @staskus!
I think we could remove isJetpack checks at some point. Also, I'm not sure if userDefaultsJetpackFeaturesDisabledKey is needed anymore unless it's used for sites without Stats (e.g. self-hosted). Either way, this might need further investigation but isn't a blocker here.
staskus
enabled auto-merge
September 8, 2023 07:02
4 tasks
crazytonyli
added a commit
that referenced
this pull request
Oct 15, 2023
This file is not used in any target. Also, it seems to be a duplication of WordPress/JetpackStatsWidgets/LocalizationConfiguration.swift. It's potentially a left-over from #21521.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #21519
Description
WordPress widget-related removals
iOS 13 widget-related removals
Targets and some of the code was removed with #19509, however, some of the code was still in the codebase and it created confusion whether it referenced iOS14 or iOS13 widgets
To test:
Regression Notes
Breaking current widget behavior, breaking fastlane flows, breaking localization flows
Manual testing, CI, and code-reviews
None
PR submission checklist:
RELEASE-NOTES.txtif necessary.