Skip to content

Fix an issue with cancel not working correctly in site media picker - #22041

Merged
kean merged 1 commit into
release/23.7from
fix/cancel-in-site-media-picker
Nov 15, 2023
Merged

Fix an issue with cancel not working correctly in site media picker#22041
kean merged 1 commit into
release/23.7from
fix/cancel-in-site-media-picker

Conversation

@kean

@kean kean commented Nov 14, 2023

Copy link
Copy Markdown
Contributor

Fixes a regression introduced in 23.7.

To test:

Regression Notes

  1. Potential unintended areas of impact: Site Media Picker
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 23.7 ❄️ milestone Nov 14, 2023
@kean
kean requested a review from crazytonyli November 14, 2023 22:55
@kean
kean force-pushed the fix/cancel-in-site-media-picker branch from beee3b3 to 601a500 Compare November 14, 2023 23:00
@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@kean
kean force-pushed the fix/cancel-in-site-media-picker branch from 601a500 to 95cafa4 Compare November 14, 2023 23:01
@wpmobilebot

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ This PR is assigned to the milestone 23.7 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22041-95cafa4
Version23.7
Bundle IDorg.wordpress.alpha
Commit95cafa4
App Center BuildWPiOS - One-Offs #7842
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@crazytonyli crazytonyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Does this issue exist in 23.6? Should add a release note if it does?

/cc @mokagio This is a PR to the 23.7 release branch.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22041-95cafa4
Version23.7
Bundle IDcom.jetpack.alpha
Commit95cafa4
App Center Buildjetpack-installable-builds #6868
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean

kean commented Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

Does this issue exist in 23.6? Should add a release note if it does?

No, it's a regression in 23.7, so no release note needed.

@kean
kean merged commit 0c519a9 into release/23.7 Nov 15, 2023
@kean
kean deleted the fix/cancel-in-site-media-picker branch November 15, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants