Fix an issue with cancel not working correctly in site media picker - #22041
Merged
Conversation
13 tasks
kean
force-pushed
the
fix/cancel-in-site-media-picker
branch
from
November 14, 2023 23:00
beee3b3 to
601a500
Compare
Generated by 🚫 dangerJS |
kean
force-pushed
the
fix/cancel-in-site-media-picker
branch
from
November 14, 2023 23:01
601a500 to
95cafa4
Compare
Contributor
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22041-95cafa4 | |
| Version | 23.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 95cafa4 | |
| App Center Build | WPiOS - One-Offs #7842 |
crazytonyli
approved these changes
Nov 14, 2023
crazytonyli
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix!
Does this issue exist in 23.6? Should add a release note if it does?
/cc @mokagio This is a PR to the 23.7 release branch.
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22041-95cafa4 | |
| Version | 23.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 95cafa4 | |
| App Center Build | jetpack-installable-builds #6868 |
Contributor
Author
No, it's a regression in 23.7, so no release note needed. |
4 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes a regression introduced in 23.7.
To test:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: