Update Aztec to use new media pickers (requires Xcode 15) - #22060
Merged
Conversation
kean
force-pushed
the
task/update-aztec
branch
from
November 17, 2023 21:07
fe2145c to
8a8e7d2
Compare
Contributor
Author
|
FYI, @twstokes. |
kean
force-pushed
the
task/update-aztec
branch
from
November 17, 2023 21:10
fcdbc79 to
7b140bb
Compare
Contributor
Author
|
Hey, @mokagio. What's the timeline for switching to Xcode 15? This PR requires iOS 17 SDK. |
momo-ozawa
approved these changes
Nov 20, 2023
momo-ozawa
left a comment
Contributor
There was a problem hiding this comment.
Works as described! 1 small thing - I'm not sure if this is an iOS 17 issue, or a simulator issue, but when I launch the Aztec editor the toolbar is partially obscured. I think normally this shouldn't be a problem because the keyboard will be displayed underneath the toolbar, but thought it may be worth mentioning
4 tasks
Contributor
This is awesome. Thank you! |
Squashed commits: [0989edb] Remove deprecated code
kean
force-pushed
the
task/update-aztec
branch
from
November 27, 2023 13:32
7b140bb to
1099db6
Compare
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22060-dc03e76 | |
| Version | 23.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | dc03e76 | |
| App Center Build | WPiOS - One-Offs #7964 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22060-dc03e76 | |
| Version | 23.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | dc03e76 | |
| App Center Build | jetpack-installable-builds #6988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is one of the remaining prerequisites for fully decommissioning WPMediaPicker.
Note: this PR requires Xcode 15; please test it locally.
Changes
SiteMediaPickerViewControllerfor selection from your site mediaPHPickerViewControllerfor selection from PhotosUIImagePickerControllerfor camera capturePHPickerViewControllerto replace the embedded picker. It’s available only on iOS 17, which I think is an acceptable trade-off, considering the extremely low number of Aztec users and people who use this option. The iOS 17 adoption has been lagging behind, but by the time this release I expect at least 50% of users to be on iOS 17. I considered implementing a custom picker using Photos.framework andPHAsset, but since the app no longer asks for Photos permissions anywhere else, I don't think it's viable. It also would've required full access to Photos (not "Only Selected")To test:
Prerequisite: In
EditorFactory.swift, updateEditorFactoryinstantiateEditor` to always return Aztec.Embedded picker
Inserting Media
Keyboard Toolbar
iOS 16 and Earlier
Camera
Photos
PHPickerViewControllerSite Media
PHPickerViewControllerRegression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: