Co-branding JP login screen with WP.com

[alpavanoglu]

Fixes: https://github.com/Automattic/jetpack-mobile-roadmap/issues/96
PT: pcdRpT-58l-p2

This PR redesigns the Jetpack app’s welcome screen to include more references to the WordPress brand, such as colours and logo.

Before Light	After Light
Before Dark	After Dark
------	-----

Testing Steps

Install & Launch Jetpack App and verify the colors match the designs in light and dark modes.

Regression Notes

1. Potential unintended areas of impact
   N/A

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/A

3. What automated tests I added (or what prevented me from doing so)
   Only UI related changes

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22296-1d02d3b
	Version	23.9
	Bundle ID	org.wordpress.alpha
	Commit	1d02d3b
	App Center Build	WPiOS - One-Offs #8317

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22296-1d02d3b
	Version	23.9
	Bundle ID	com.jetpack.alpha
	Commit	1d02d3b
	App Center Build	jetpack-installable-builds #7341

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[alpavanoglu]

There's an issue on button view's background color on iPad. I'm trying to find a solution without modifying the WordPressAuthenticator.

[alpavanoglu]

This resolves the iPad issue. However I am not sure what the pod target here should be. It was targeting a specific commit before as well but this doesn't sounds great. @mokagio perhaps you would have more information about this? Is there a reason why this pod isn't targeting a specific release?

[mokagio]

This resolves the iPad issue.

That's great. Thanks!

I noticed there's not a PR for it yet but I assume one will be opened soon, right?

However I am not sure what the pod target here should be. It was targeting a specific commit before as well but this doesn't sounds great.

It's okay to target commits for the pods during development. That is, only release/ branches should always point to stable pods and other libraries. More info at paNNhX-K4-p2

The one thing to be aware when changing from one commit to another is to make sure that the new commit is after the original one, so that both changes are present. That is, of course, unless the second commit directly aims at fixing an issue in the orginal one, for example by switching for "experimental branch for feature X number 1" to "experimental branch for feature X number 2".

Is there a reason why this pod isn't targeting a specific release?

The procedure above should answer this question, too. For reference, the PR that changed it is #21904.

Hope this helps.

[justtwago]

Have you considered using .webp images instead of .pdf? I see it's supported by Apple starting from iOS 14. The format drastically reduces image weight.
For instance, here is the result on Android:

[alpavanoglu]

4mb is indeed plenty to add to the binary even though the PR reduces the binary due to the fact that the new image is smaller in size than the old one. I assume .webp wouldn't be very common in iOS but I don't know if there's any reason for that apart from that fact that it is rather newer. I'll take a look and update it as such if I can't find a reason not to do that. Thanks for the heads up!

[salimbraksa]

The next version is 24.0. Don't forget to move this release not to 24.0.

[salimbraksa]

I've tested the new UI on iPhone and iPad and LGTM! 👍