This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add background view to the LoginPrologueViewController.swift#821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: wordpress-mobile/WordPress-iOS#22296
Description
This PR fixes the issue where setting the background color for the buttons did not work in iPad as the background for the buttons did not cover the full width. Adding a view behind the buttons container and setting the background color to the same value, resolved the issue.
Testing Steps
Follow the steps on referenced PR and confirm the UI has no such aforementioned oddity on iPad.
CHANGELOG.mdif necessary.