Skip to content

Bottom tab improvements: Enable feature flag - #22344

Merged
mokagio merged 2 commits into
release/24.0from
task/enable-feature-flag
Jan 9, 2024
Merged

Bottom tab improvements: Enable feature flag#22344
mokagio merged 2 commits into
release/24.0from
task/enable-feature-flag

Conversation

@momo-ozawa

Copy link
Copy Markdown
Contributor

Enables #22325

How to test

  • Verify new bottom tab icons are enabled
  • Verify icon animation work

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 24.0 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22344-7efa1d7
Version24.0
Bundle IDorg.wordpress.alpha
Commit7efa1d7
App Center BuildWPiOS - One-Offs #8368
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22344-7efa1d7
Version24.0
Bundle IDcom.jetpack.alpha
Commit7efa1d7
App Center Buildjetpack-installable-builds #7390
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio

mokagio commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

Taking over merging as I'm about to start a new build for 24.0

@mokagio
mokagio merged commit 3068ce3 into release/24.0 Jan 9, 2024
@mokagio
mokagio deleted the task/enable-feature-flag branch January 9, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants