Remove AppConstants

[kean]

Self-explanatory.

To test:

• Both apps don't crash
• Verify line-by-line that the values were moved accurately, please

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[crazytonyli]

All of these are just hard-coded values which don't have anything to do with build configurations. Maybe we can just have some readonly variables or something? I don't think all these values need to be in the Info.plist files.

[mokagio]

All of these are just hard-coded values which don't have anything to do with build configurations

True. However, they do change from WordPress and Jetpack. Maybe we could derive them from brand/WPAppBrand. But then we'd have sort of two places where to place the values: Info.plist and the code switch brand { case ... here.

[kean]

two places where to place the values: Info.plist and the code switch brand { case ... here.

💯. The idea is to specify configuration in data: Info.plist and .xcconfig. It's not always feasible, but you generally shouldn't have to search the codebase to find these values – it should be in configuration files, in data. I used switch brand sparingly.

There are multiple advantages to storing these values in data and not code: easier to find, can be modified without recompiling the app, easier to edit with scripts if needed.

[mokagio]

I think I know why the builds are failing...

---

Update: Finally got CI validation #24297

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 25.9. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr24294-4b6cb2f
	Version	25.8
	Bundle ID	org.wordpress.alpha
	Commit	4b6cb2f
	App Center Build	WPiOS - One-Offs #11818

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr24294-4b6cb2f
	Version	25.8
	Bundle ID	com.jetpack.alpha
	Commit	4b6cb2f
	App Center Build	jetpack-installable-builds #10841

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[pmusolino]

I just did a general smoke test, and I didn't find any crashes 👍

[pmusolino]

Should this be mobile_-_wp_ios? Is there a reason why we do not identify the app?

[kean]

I copied the value from https://github.com/wordpress-mobile/WordPress-iOS/blob/trunk/WordPress/Classes/Utility/App%20Configuration/AppConstants.swift:

 static let zendeskSourcePlatform = "mobile_-_ios"