Remove https:// from Info.plist to address compilation fail - #24297
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Apparently, Xcode/`xcodebuild` fails to parse it, see how https://buildkite.com/automattic/wordpress-ios/builds/26578/steps?jid=0195bb59-1f1a-40ad-89c9-3964c36cff28#0195bb59-1f1a-40ad-89c9-3964c36cff28/973-5502 failed and notice the build for this commit passes.
mokagio
force-pushed
the
mokagio/fix-build-settings-https
branch
from
March 24, 2025 09:50
7c774b4 to
6054c9e
Compare
mokagio
added a commit
that referenced
this pull request
Mar 24, 2025
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24297-6054c9e | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 6054c9e | |
| App Center Build | WPiOS - One-Offs #11814 |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24297-6054c9e | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 6054c9e | |
| App Center Build | jetpack-installable-builds #10836 |
mokagio
commented
Mar 24, 2025
Comment on lines
+43
to
+46
| func urlValue(forKey key: String) -> URL { | ||
| let urlWithoutScheme: String = infoValue(forKey: key) | ||
| return URL(string: "https://\(urlWithoutScheme)")! | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This could be improved with a fallback like if the strings already has "https://" at the start, don't prefix it with it.
mokagio
commented
Mar 24, 2025
Comment on lines
-26
to
+28
| <string>https://twitter.com/WordPressiOS</string> | ||
| <string>twitter.com/WordPressiOS</string> | ||
| <key>WPProductBlogURL</key> | ||
| <string>https://wordpress.org/news/</string> | ||
| <string>wordpress.org/news/</string> |
Contributor
Author
There was a problem hiding this comment.
This approach fixes the issue but introduces the undocumented and unforced rule of having URLs specified without the schema.
mokagio
marked this pull request as ready for review
March 24, 2025 10:49
Contributor
|
Ah, right. I don't know how I tested it – evidently I did not. I'm pretty sure you can put URLs in regular .plist files without preprocessing and it simply escapes them. Thanks for addressing it! For a single key/value, I think it's good enough. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
* Move some content group and styles to FormattableContentKit These are needed by the WordPressData files. * Address SwiftLint violations * Change `formatter` to `private` * Add note to address #24297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #24294 to address a build failure seen in CI and reproducible locally running Fastlane.
Apparently, Xcode/
xcodebuildfails to parse straight "https://" inInfo.plists, see how https://buildkite.com/automattic/wordpress-ios/builds/26578/steps?jid=0195bb59-1f1a-40ad-89c9-3964c36cff28#0195bb59-1f1a-40ad-89c9-3964c36cff28/973-5502 failed and notice the build for this commit passes.