Skip to content

Remove a few redundant build setting overrides from Keystone - #24371

Merged
mokagio merged 3 commits into
trunkfrom
mokagio/keystone-settings-tidy
Apr 1, 2025
Merged

Remove a few redundant build setting overrides from Keystone#24371
mokagio merged 3 commits into
trunkfrom
mokagio/keystone-settings-tidy

Conversation

@mokagio

@mokagio mokagio commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Part of #24165.

I've been replaying the changes from #24242 on top of the latest trunk with the new Keystone framework. See the mokagio/wordpressdata-target-xcdatamodeld-workbench-2 branch.

The first step was to recreate the WordPressData framework. I wanted it to have the same settings as Keystone, at least to begin with.

image

In checking the settings side by side, I noticed a few overrides that were ripe for removal. Replayed here in a dedicated PR for ease of reviewing.

@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Apr 1, 2025
@mokagio mokagio self-assigned this Apr 1, 2025
@mokagio
mokagio requested review from crazytonyli and kean April 1, 2025 00:10
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number26955
VersionPR #24371
Bundle IDorg.wordpress.alpha
Commitec4f63a
Installation URL0vjjngmqepis0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number26955
VersionPR #24371
Bundle IDcom.jetpack.alpha
Commitec4f63a
Installation URL7hmf0dgjh3l40
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio
mokagio enabled auto-merge April 1, 2025 00:22
@mokagio
mokagio added this pull request to the merge queue Apr 1, 2025
Merged via the queue into trunk with commit d104acb Apr 1, 2025
@mokagio
mokagio deleted the mokagio/keystone-settings-tidy branch April 1, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants