Remove a few redundant build setting overrides from Keystone - #24371
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
kean
approved these changes
Apr 1, 2025
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 26955 | |
| Version | PR #24371 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | ec4f63a | |
| Installation URL | 0vjjngmqepis0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 26955 | |
| Version | PR #24371 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ec4f63a | |
| Installation URL | 7hmf0dgjh3l40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Part of #24165.
I've been replaying the changes from #24242 on top of the latest
trunkwith the new Keystone framework. See themokagio/wordpressdata-target-xcdatamodeld-workbench-2branch.The first step was to recreate the WordPressData framework. I wanted it to have the same settings as Keystone, at least to begin with.
In checking the settings side by side, I noticed a few overrides that were ripe for removal. Replayed here in a dedicated PR for ease of reviewing.