Skip to content

Work bench PR for one-go Core Data extraction into target - #24242

Closed
mokagio wants to merge 125 commits into
trunkfrom
mokagio/wordpressdata-target-xcdatamodeld
Closed

Work bench PR for one-go Core Data extraction into target#24242
mokagio wants to merge 125 commits into
trunkfrom
mokagio/wordpressdata-target-xcdatamodeld

Conversation

@mokagio

@mokagio mokagio commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Part of #24165

@dangermattic

dangermattic commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator
3 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@mokagio
mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch 5 times, most recently from d2f7b4a to cd16cf0 Compare March 18, 2025 21:01
This was referenced Mar 18, 2025
Merged
Closed
Closed
@mokagio
mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch 2 times, most recently from 2abe7e2 to ff62040 Compare March 19, 2025 18:23
@wpmobilebot

wpmobilebot commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24242-747f1b3
Version25.8
Bundle IDorg.wordpress.alpha
Commit747f1b3
App Center BuildWPiOS - One-Offs #11830
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24242-747f1b3
Version25.8
Bundle IDcom.jetpack.alpha
Commit747f1b3
App Center Buildjetpack-installable-builds #10853
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio
mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch 3 times, most recently from 20348f6 to 6b23c53 Compare March 20, 2025 09:23
This was referenced Mar 20, 2025
Merged
Open
@mokagio
mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch 8 times, most recently from b879f41 to 8c0b6bd Compare March 26, 2025 10:06
mokagio added a commit that referenced this pull request Mar 26, 2025
@mokagio
Update access level for types that will go into WordPressData
0db5fb2 
This comes from the "workbench" work from
#24242
@mokagio mokagio mentioned this pull request Mar 26, 2025
Merged
mokagio added a commit that referenced this pull request Mar 26, 2025
@mokagio
Update access level for types that will go into WordPressData
38b0445 
This comes from the "workbench" work from
#24242
mokagio added a commit that referenced this pull request Mar 26, 2025
@mokagio
Update access level for types that will go into WordPressData
25cceb0 
This comes from the "workbench" work from
#24242
mokagio added 23 commits March 31, 2025 13:25
@mokagio
Port Blog dotComID and willSave to Swift
7c30466
@mokagio
Port siteVisibility Blog property to Swift
7469cd7
@mokagio
Update after rebase - SharingAuthorizationHelper.m
724c888
@mokagio
Update after rebase - Blog.m
0237693
@mokagio
Update after rebase - WPAccount+RestApi.swift
1c82fa6
@mokagio
Fix after rebase - PostVisibility.swift
770f767
@mokagio
Remove duplicated import
93f5fd4
@mokagio
Fix after rebase - StatsViewController.m
08203ad
@mokagio
Remove code disable during WordPressData move in Comment
6441336
@mokagio
Remove code disable during WordPressData move in ReaderSiteTopic
9939f99
@mokagio
Re-enable wpAssert calls in WordPressData thanks to #24346
0b2121c
@mokagio
Remove code disable during WordPressData move in ReaderCard
52aaa2a
@mokagio
Remove "module WordPress" from xcdatamodel entities that had it
c0e29d0 
This way, the app will look for the model object in WordPressData, which
is where they are defined.
@mokagio
Fix after rebase - Rename .enterprise.xcconfig to .alpha.xcconfig
02528a5
@mokagio
Put all models in the global namespace
d92acd7
@mokagio
Fix after rebase - Remove duplicated SiteOrganizationType
718bd7d
@mokagio
Delete stray empty NotificationContentFactory.swift file
da1c75a
@mokagio
Remove NotificationSyncMediatorProtocol from WordPressData
b4b63cb 
Does not need to be in there.
@mokagio
Remove code disable during WordPressData move in ReaderCrossPostMeta
b11795f
@mokagio
Update after rebase - Use Common.*.xcconfig for WordPressData
ef96aff
@mokagio
DRY test logic to generate BlogSettings instance
df4e142
@mokagio
Address typecast warning for a Blog assignment in tests
2384a16
@mokagio
Hack tests to avoid failing to get BlogSettings from DB
ae902cc
@mokagio
mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch from c80d7ea to ae902cc Compare March 31, 2025 03:30
github-merge-queue Bot pushed a commit that referenced this pull request Mar 31, 2025
@mokagio
Update access level for types that will go into WordPressData – Round…
8b76ab8 
… 2 (#24348)

* Update access level for types that will go into WordPressData

All the changes are extracted from the "work bench" work from
#24242 with the
goal of reducing that PRs diff size to make it easier to review and
identify errors.

* Fix (?) `NullBlogPropertySanitizer` compilation

* Update access level for more types that will go into WordPressData
This was referenced Apr 1, 2025
Merged
Merged
@mokagio

mokagio commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

Closing in favor of #24378

@mokagio mokagio closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mokagio @dangermattic @wpmobilebot