Skip to content

Inherit CODE_SIGN_STYLE in Keystone—makes it Manual - #24377

Merged
mokagio merged 1 commit into
trunkfrom
mokagio/keystone-provisioning-settings
Apr 1, 2025
Merged

Inherit CODE_SIGN_STYLE in Keystone—makes it Manual#24377
mokagio merged 1 commit into
trunkfrom
mokagio/keystone-provisioning-settings

Conversation

@mokagio

@mokagio mokagio commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

This addresses a provisioning settings that would have resulting in targets using the framework failing to build for distribution.

Keystone has conflicting provisioning settings.
Keystone is automatically signed, but code signing identity Apple Development: Created via API (886NX39KP6) has been manually specified.
Set the code signing identity value to "Apple Development" in the build settings editor, or switch to manual signing in the Signing & Capabilities editor.

Before

image

After

image

These are the same settings WordPressAuthenticator uses.

I noticed this while troubleshooting #24374

This addresses a provisioning settings that would have resulting in
targets using the framework failing to build for distribution.

> Keystone has conflicting provisioning settings.
> Keystone is automatically signed, but code signing identity Apple Development: Created via API (886NX39KP6) has been manually specified.
> Set the code signing identity value to "Apple Development" in the build settings editor, or switch to manual signing in the Signing & Capabilities editor.
@mokagio
mokagio requested review from crazytonyli and kean April 1, 2025 11:10
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Apr 1, 2025
@mokagio mokagio added this to the 25.9 milestone Apr 1, 2025
@mokagio
mokagio enabled auto-merge April 1, 2025 11:10
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number26988
VersionPR #24377
Bundle IDcom.jetpack.alpha
Commit498f29e
Installation URL0rqjjnbh41g8o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number26988
VersionPR #24377
Bundle IDorg.wordpress.alpha
Commit498f29e
Installation URL2t274pqlv08i0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio
mokagio added this pull request to the merge queue Apr 1, 2025
Merged via the queue into trunk with commit b9bc67a Apr 1, 2025
@mokagio
mokagio deleted the mokagio/keystone-provisioning-settings branch April 1, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants