Add empty WordPressData target + custom test plan - #24374
Merged
mokagio merged 13 commits intoApr 1, 2025
Conversation
mokagio
added
Tooling
Collaborator
Generated by 🚫 Danger |
mokagio
marked this pull request as draft
April 1, 2025 03:14
It's not time for that yet
The issue is that I named the framework and the package both WordPressData and that we already have existing `import`s of it in production and test code. To keep the diff simple, I decided to leave those imports in place and simply: - Remove the WordPressData package (empty) dependency - Add explicit WordPressDataObjc package (empty) dependency - Add WordPressData framework (empty) dependency This sorts the compilation and running locally. As we'll move files to WordPressData and/or away from Keystone, we might need to change this approach.
See how this build https://buildkite.com/automattic/wordpress-ios/builds/26971 failed
mokagio
force-pushed
the
mokagio/wordpressdata-target-xcdatamodeld-workbench-2
branch
from
April 1, 2025 10:42
21e1419 to
e0b796d
Compare
This was referenced Apr 1, 2025
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 26991 | |
| Version | PR #24374 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | d1d883c | |
| Installation URL | 7tad5thar0fq0 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 26991 | |
| Version | PR #24374 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | d1d883c | |
| Installation URL | 379f6uf331ls8 |
mokagio
marked this pull request as ready for review
April 1, 2025 11:44
kean
approved these changes
Apr 1, 2025
mokagio
deleted the
mokagio/wordpressdata-target-xcdatamodeld-workbench-2
branch
April 1, 2025 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid long lived branches like #24242 and integration issues as the work on Keystone advances, here's a PR that at leasts adds the scaffolding for WordPressData so we'll be able to add sources and tests there in the future.
Part of #24165