Skip to content

Make some @objc methods public so WordPressData can access them - #24386

Merged
mokagio merged 1 commit into
trunkfrom
mokagio/wordpressdata-access-level-3
Apr 1, 2025
Merged

Make some @objc methods public so WordPressData can access them#24386
mokagio merged 1 commit into
trunkfrom
mokagio/wordpressdata-access-level-3

Conversation

@mokagio

@mokagio mokagio commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

I never looked into it, but apparently the public access level for @objc is required in a framework setup for those methods to be accessible through the <framework name>-Swift.h generated header.

We run into the same issue in Keystone, see #24383

Part of #24165

I never looked into it, but apparently the `public` access level for
`@objc` is required in a framework setup for those methods to be
accessible through the `<framework name>-Swift.h` generated header.

We run into the same issue in Keystone, see
#24383
@mokagio
mokagio requested review from crazytonyli and kean April 1, 2025 18:26
@mokagio mokagio self-assigned this Apr 1, 2025
@mokagio mokagio added the Core Data Issues related to Core Data label Apr 1, 2025
@mokagio mokagio added this to the 25.9 milestone Apr 1, 2025
@mokagio
mokagio enabled auto-merge April 1, 2025 18:27
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27010
VersionPR #24386
Bundle IDorg.wordpress.alpha
Commit932f1dd
Installation URL515bhgjct8tgo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27010
VersionPR #24386
Bundle IDcom.jetpack.alpha
Commit932f1dd
Installation URL0n64q0l2olmqg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio
mokagio added this pull request to the merge queue Apr 1, 2025
Merged via the queue into trunk with commit fa4bcae Apr 1, 2025
@mokagio
mokagio deleted the mokagio/wordpressdata-access-level-3 branch April 1, 2025 19:27
@kean kean mentioned this pull request Apr 1, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Data Issues related to Core Data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants