Skip to content

Add some missing access modifiers - #24388

Merged
kean merged 2 commits into
trunkfrom
task/keystone-precursors-dlgnlk1ejklcdj
Apr 1, 2025
Merged

Add some missing access modifiers#24388
kean merged 2 commits into
trunkfrom
task/keystone-precursors-dlgnlk1ejklcdj

Conversation

@kean

@kean kean commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

same story as #24386 but for Keystone

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Apr 1, 2025
@kean kean added this to the 25.9 milestone Apr 1, 2025
@kean
kean requested review from crazytonyli and mokagio April 1, 2025 19:54
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@mokagio
mokagio requested a review from Copilot April 1, 2025 20:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (13)
  • WordPress/Classes/Extensions/Colors and Styles/UIColor+MurielColorsObjC.swift: Language not supported
  • WordPress/Classes/Models/Blog/Blog+Creation.swift: Language not supported
  • WordPress/Classes/Models/Blog/Blog+WordPressComRestAPI.swift: Language not supported
  • WordPress/Classes/Models/ReaderPost+Swift.swift: Language not supported
  • WordPress/Classes/Services/MediaRepository.swift: Language not supported
  • WordPress/Classes/Services/NotificationSupportService.swift: Language not supported
  • WordPress/Classes/Stores/StatsPeriodCache.swift: Language not supported
  • WordPress/Classes/System/WordPressAppDelegate.swift: Language not supported
  • WordPress/Classes/Utility/Analytics/WPAnalytics+Domains.swift: Language not supported
  • WordPress/Classes/Utility/Analytics/WPAnalyticsEvent.swift: Language not supported
  • WordPress/Classes/Utility/Analytics/WPAppAnalytics+Extensions.swift: Language not supported
  • WordPress/Classes/Utility/Notifications/PushNotificationsManager.swift: Language not supported
  • WordPress/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift: Language not supported

@mokagio mokagio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this as a dedicated PR.

Easy to review, just scroll and check the green pattern of public. Then, if CI is green, we're good to merge.

I asked Copilot to review just out of curiosity.

PS. Love the unique identifier in the branch name.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27023
VersionPR #24388
Bundle IDorg.wordpress.alpha
Commit5c3916d
Installation URL2a1dg6dot9clo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean
kean enabled auto-merge April 1, 2025 20:17
@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27023
VersionPR #24388
Bundle IDcom.jetpack.alpha
Commit5c3916d
Installation URL3fh723776k85g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean
kean added this pull request to the merge queue Apr 1, 2025
Merged via the queue into trunk with commit 5eabfdc Apr 1, 2025
@kean
kean deleted the task/keystone-precursors-dlgnlk1ejklcdj branch April 1, 2025 21:05
@kean kean mentioned this pull request Apr 1, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants