Add some missing access modifiers - #24388
Merged
Merged
Conversation
Collaborator
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (13)
- WordPress/Classes/Extensions/Colors and Styles/UIColor+MurielColorsObjC.swift: Language not supported
- WordPress/Classes/Models/Blog/Blog+Creation.swift: Language not supported
- WordPress/Classes/Models/Blog/Blog+WordPressComRestAPI.swift: Language not supported
- WordPress/Classes/Models/ReaderPost+Swift.swift: Language not supported
- WordPress/Classes/Services/MediaRepository.swift: Language not supported
- WordPress/Classes/Services/NotificationSupportService.swift: Language not supported
- WordPress/Classes/Stores/StatsPeriodCache.swift: Language not supported
- WordPress/Classes/System/WordPressAppDelegate.swift: Language not supported
- WordPress/Classes/Utility/Analytics/WPAnalytics+Domains.swift: Language not supported
- WordPress/Classes/Utility/Analytics/WPAnalyticsEvent.swift: Language not supported
- WordPress/Classes/Utility/Analytics/WPAppAnalytics+Extensions.swift: Language not supported
- WordPress/Classes/Utility/Notifications/PushNotificationsManager.swift: Language not supported
- WordPress/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift: Language not supported
mokagio
approved these changes
Apr 1, 2025
Contributor
There was a problem hiding this comment.
Thank you for opening this as a dedicated PR.
Easy to review, just scroll and check the green pattern of public. Then, if CI is green, we're good to merge.
I asked Copilot to review just out of curiosity.
PS. Love the unique identifier in the branch name.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27023 | |
| Version | PR #24388 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5c3916d | |
| Installation URL | 2a1dg6dot9clo |
kean
enabled auto-merge
April 1, 2025 20:17
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27023 | |
| Version | PR #24388 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5c3916d | |
| Installation URL | 3fh723776k85g |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


same story as #24386 but for Keystone
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: