Skip to content

Add missing access control modifiers - #24390

Merged
kean merged 1 commit into
trunkfrom
task/keystone-precursor-vkdnvkn31oir
Apr 2, 2025
Merged

Add missing access control modifiers#24390
kean merged 1 commit into
trunkfrom
task/keystone-precursor-vkdnvkn31oir

Conversation

@kean

@kean kean commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Same deal as #24388. Only public adds.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Apr 1, 2025
@kean kean added this to the 25.9 milestone Apr 1, 2025
@kean
kean force-pushed the task/keystone-precursor-vkdnvkn31oir branch from 56f2b6a to 9ea4510 Compare April 1, 2025 22:06
@kean
kean requested review from crazytonyli and mokagio and removed request for crazytonyli April 1, 2025 22:07
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean
kean requested a review from crazytonyli April 1, 2025 22:07
@kean
kean enabled auto-merge April 1, 2025 22:07
@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27036
VersionPR #24390
Bundle IDorg.wordpress.alpha
Commit9ea4510
Installation URL42ub7ap7b53no
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27036
VersionPR #24390
Bundle IDcom.jetpack.alpha
Commit9ea4510
Installation URL175f8ckenuk98
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

import WordPressKit

public extension Blog {
extension Blog {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask why this is no longer public but I'm pretty sure it's because the modifier is redundant given both members are declared as public.


// MARK: - Private Constants
fileprivate struct Defaults {
private struct Defaults {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@kean
kean added this pull request to the merge queue Apr 2, 2025
Merged via the queue into trunk with commit 731a653 Apr 2, 2025
@kean
kean deleted the task/keystone-precursor-vkdnvkn31oir branch April 2, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants