Skip to content

Rewrite AccountService in Swift (parts) - #24404

Merged
kean merged 6 commits into
trunkfrom
task/rewrite-account-service-in-swift
Apr 7, 2025
Merged

Rewrite AccountService in Swift (parts)#24404
kean merged 6 commits into
trunkfrom
task/rewrite-account-service-in-swift

Conversation

@kean

@kean kean commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

For Keystone.

To test: login, restart the app and verify you are still logged in, logout.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Apr 3, 2025
@kean kean added this to the 25.9 milestone Apr 3, 2025
@kean
kean force-pushed the task/rewrite-account-service-in-swift branch from 9413c1a to 96dedd4 Compare April 3, 2025 13:36
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean
kean requested review from crazytonyli and mokagio April 3, 2025 13:38
@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27096
VersionPR #24404
Bundle IDorg.wordpress.alpha
Commit96dedd4
Installation URL7810e1gd77k8o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27096
VersionPR #24404
Bundle IDcom.jetpack.alpha
Commit96dedd4
Installation URL4hjeodlf0tlb8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean mentioned this pull request Apr 3, 2025
14 tasks
@kean
kean added this pull request to the merge queue Apr 7, 2025
Merged via the queue into trunk with commit 96b46d3 Apr 7, 2025
@kean
kean deleted the task/rewrite-account-service-in-swift branch April 7, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants