Add remaining public APIs for Keystone - #24406
Merged
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27102 | |
| Version | PR #24406 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 6632d02 | |
| Installation URL | 225h8o39hfgh0 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27102 | |
| Version | PR #24406 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 6632d02 | |
| Installation URL | 3343ju8d5f2ag |
crazytonyli
approved these changes
Apr 6, 2025
Contributor
|
Unlocked merging to address conflicts with #24378, if any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR gets Keystone to compile again (when #24399 and #24404 are also merged). It contains a lot of no-brainer changes, but there are some minor Swift rewrites too (also no-brainer).
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: