Remove the remaining WordPressAuthenticator usages - #25645
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32627 | |
| Version | PR #25645 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | ad92a12 | |
| Installation URL | 7jm5fo6lunnf0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32627 | |
| Version | PR #25645 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ad92a12 | |
| Installation URL | 2pn0545us3e3g |
crazytonyli
force-pushed
the
task/remove-authenticator-phase3
branch
from
June 15, 2026 00:15
6d3ddec to
f236cc6
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase4
branch
2 times, most recently
from
June 15, 2026 00:50
93f49c2 to
2dd2128
Compare
crazytonyli
marked this pull request as ready for review
June 15, 2026 01:12
crazytonyli
force-pushed
the
task/remove-authenticator-phase3
branch
from
June 15, 2026 01:23
999b5a8 to
02e5cf5
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase4
branch
from
June 15, 2026 01:23
2dd2128 to
c567244
Compare
jkmassel
approved these changes
Jun 15, 2026
WordPressAuthenticationManager no longer initializes or configures the library: the configuration and style builders, the WordPressAuthenticatorDelegate conformance, the native sign-up epilogue presentation, and the credential sync helpers are gone, leaving only the re-auth observers and the sign-in epilogue presenters that live code calls. The AuthenticationHandler protocol, JetpackAuthenticationManager, the signUp feature flag, and the NUXButtonStyle vendors in the prologue style guides are deleted along with their last consumers. The app delegate also drops the Sign in with Apple credential-revocation observers, an approved product decision: users who signed in with Apple are no longer automatically signed out when they revoke the credential.
crazytonyli
force-pushed
the
task/remove-authenticator-phase4
branch
from
June 15, 2026 03:21
c567244 to
ad92a12
Compare
crazytonyli
enabled auto-merge
June 15, 2026 03:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25644. I recommend reviewing this PR commit by commit.
Description
Continuing the WordPressAuthenticator removal: the previous PR stopped the app from calling the library's APIs, and this PR deletes the now-dead integration code. The library itself is deleted in the next PR.
WordPressAuthenticatorDelegatemachinery.WordPressAuthenticationManagerno longer configures or styles the library, andAuthenticationHandler,JetpackAuthenticationManager, thesignUpfeature flag, and theNUXButtonStylevendors in the prologue style guides are deleted along with their last consumers.SignupEpilogue.storyboard, and the epilogue cells.StatsWidgetsStoreJetpack-login observer, theUnifiedPrologueViewControllertracking call, and the dead login/signup UI test screens.